Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dockerfile for crossbuilds #19

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix Dockerfile for crossbuilds #19

merged 2 commits into from
Feb 9, 2024

Conversation

emcfarlane
Copy link
Contributor

Correct the Dockerfile for crossbuilds. The following two issues were corrected:

  • Set the env vars for each go install command
  • Correct the move command to capture the ${TARGETOS} correctly

pkwarren
pkwarren reviewed Feb 9, 2024
View reviewed changes
cmd/protoc-gen-multi/README.md Show resolved Hide resolved
cmd/protoc-gen-multi/README.md Show resolved Hide resolved
cmd/protoc-gen-multi/README.md Outdated Show resolved Hide resolved
@emcfarlane @pkwarren
Update cmd/protoc-gen-multi/README.md
422db14 
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
@emcfarlane emcfarlane merged commit 60cc22c into main Feb 9, 2024
4 checks passed
@emcfarlane emcfarlane deleted the ed/fixMultiDocker branch February 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMarby DMarby DMarby approved these changes

@pkwarren pkwarren pkwarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emcfarlane @DMarby @pkwarren