Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish protoc-gen-multi for combined plugins #11

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

emcfarlane
Copy link
Contributor

Combine multiple protoc plugin invocations into one with protoc-gen-multi. Publish a custom plugin which can invoke multiple protoc plugins with support for Generated SDKs. See README.md for details.

@mfridman mfridman marked this pull request as ready for review January 29, 2024 15:15
@mfridman
Copy link
Member

I don't think we need extensive tests here, but if we wanted a bit of confidence we could pass a testdata code gen request and assert for the generated files:

.
└── connectrpc
    └── eliza
        └── v1
            ├── eliza.pb.go
            ├── eliza_grpc.pb.go
            └── eliza_vtproto.pb.go

@emcfarlane
Copy link
Contributor Author

@mfridman added a test using testdata/request.json which is a pluginpb.CodeGeneratorRequest that will try invoke protoc-gen-go if available and check it gets some content.

@emcfarlane emcfarlane merged commit c49899b into main Jan 29, 2024
2 checks passed
@emcfarlane emcfarlane deleted the ed/protoc-gen-multi branch January 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants