Skip to content

Commit

Permalink
Use make lint in CI instead of golangci-lint action (#70)
Browse files Browse the repository at this point in the history
Run `make lint` in CI instead of using the action to make sure CI is
consistent with running `make lint` locally.
  • Loading branch information
oliversun9 authored Oct 26, 2023
1 parent 1ef4888 commit c660246
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
9 changes: 1 addition & 8 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,4 @@ jobs:
# Often, lint guidelines depend on the Go version. To prevent
# conflicting guidance, run only on the most recent supported version.
if: matrix.go-version == 'stable'
uses: golangci/golangci-lint-action@v3
with:
skip-pkg-cache: true
only-new-issues: true
args: >
--modules-download-mode=readonly
--timeout=3m0s
./...
run: make lint
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ lint: lint-proto lint-go ## Lint code and protos

.PHONY: lint-go
lint-go: $(BIN)/golangci-lint
$(BIN)/golangci-lint run ./...
$(BIN)/golangci-lint run --modules-download-mode=readonly --timeout=3m0s ./...

.PHONY: lint-proto
lint-proto: $(BIN)/buf
Expand Down

0 comments on commit c660246

Please sign in to comment.