Remove dead branches for null handling in fromJson #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudlow
commented
Dec 11, 2025
| nullAsZeroValue: boolean, | ||
| ): number | typeof tokenNull | typeof tokenIgnoredUnknownEnum { | ||
| if (json === null) { | ||
| if (desc.typeName == "google.protobuf.NullValue") { |
Contributor
Author
There was a problem hiding this comment.
desc.typeName == "google.protobuf.NullValue" was always true in calls where nullAsZeroValue was true.
hudlow
commented
Dec 11, 2025
Comment on lines
-488
to
-490
| if (nullAsZeroValue) { | ||
| return scalarZeroValue(field.scalar, false); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
All calls that passed nullAsZeroValue as true also guaranteed that json was not null.
Member
|
Good catch. This means we can eliminate |
Base automatically changed from
tstamm/Permit-google.protobuf.Value.null_value-in-map-values-in-ProtoJSON-
to
main
December 12, 2025 15:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.