Fix Valid types for interstitial references #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
Sep 11, 2025
| msg?: VTypes; | ||
| }; | ||
|
|
||
| export declare type VTypes2Valid = VTypes2; |
There was a problem hiding this comment.
Similar to #1224, Vtypes2Valid should be a bespoke type with a property msg?: VTypesValid.
timostamm
commented
Sep 11, 2025
Comment on lines
+389
to
+396
| export declare type VTypes2Valid = Message<"spec.VTypes2"> & { | ||
| /** | ||
| * In the generated valid type, this property should point to a valid type. | ||
| * | ||
| * @generated from field: spec.VTypes msg = 1; | ||
| */ | ||
| msg?: VTypesValid; | ||
| }; |
There was a problem hiding this comment.
New gen code with this PR.
srikrsna-buf
approved these changes
Sep 11, 2025
timostamm
deleted the
tstamm/Fix-Valid-types-for-interstitial-references
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf-ES can generate a Valid type that honors proto2
requiredand the protovalidate required rule. For messages that don't use any of the relevant annotations, we generate the valid type as an alias to the regular type to avoid unnecessary repetitions.The logic to determine when to generate a complete valid type or just an alias is flawed: It doesn't consider the case where a message doesn't have any annotations itself, but references a message that does in a message field. In this case, we need a complete valid type, not just an alias.
Fixes #1224.