Update to Protobuf v27.3 (#247)

README.md

@@ -11,10 +11,10 @@ The current implementations being tested are:
 
 * Protobuf-ES: https://github.com/bufbuild/protobuf-es
 * protobuf-ts: https://github.com/timostamm/protobuf-ts
-* protobuf.js: https://github.com/protobufjs/protobuf.js
 * google-protobuf: https://github.com/protocolbuffers/protobuf-javascript
 * ts-proto: https://github.com/stephenh/ts-proto
 * protoscript: https://github.com/TateThurston/protoscript
+* protobuf.js: https://github.com/protobufjs/protobuf.js
 * protoc-gen-ts: https://github.com/thesayyn/protoc-gen-ts
 
 <!-- LIST-END -->
@@ -27,16 +27,17 @@ The current implementations being tested are:
 |---|:---:|:---:|:---:|:---:|:---:|
 | [Protobuf-ES](impl/protobuf-es) | :heavy_check_mark: | :heavy_check_mark: | :heavy_check_mark: | <sub><img src=".github/genimg/Protobuf-ES-required.svg" height="25" width="125" /></sub><br><sup>(0&nbsp;failures)<sub> | <sub><img src=".github/genimg/Protobuf-ES-recommended.svg" height="25" width="125" /></sub><br><sup>(0&nbsp;failures)<sub> |
 | [protobuf-ts](impl/protobuf-ts) | :heavy_check_mark: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/protobuf-ts-required.svg" height="25" width="125" /></sub><br><sup>(2&nbsp;failures)<sub> | <sub><img src=".github/genimg/protobuf-ts-recommended.svg" height="25" width="125" /></sub><br><sup>(1&nbsp;failures)<sub> |
-| [protobuf.js](impl/protobuf.js) | :heavy_check_mark: | :x: | :x: | <sub><img src=".github/genimg/protobuf.js-required.svg" height="25" width="125" /></sub><br><sup>(523&nbsp;failures)<sub> | <sub><img src=".github/genimg/protobuf.js-recommended.svg" height="25" width="125" /></sub><br><sup>(169&nbsp;failures)<sub> |
-| [google-protobuf](impl/google-protobuf) | :x: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/google-protobuf-required.svg" height="25" width="125" /></sub><br><sup>(572&nbsp;failures)<sub> | <sub><img src=".github/genimg/google-protobuf-recommended.svg" height="25" width="125" /></sub><br><sup>(300&nbsp;failures)<sub> |
-| [ts-proto](impl/ts-proto) | :x: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/ts-proto-required.svg" height="25" width="125" /></sub><br><sup>(736&nbsp;failures)<sub> | <sub><img src=".github/genimg/ts-proto-recommended.svg" height="25" width="125" /></sub><br><sup>(607&nbsp;failures)<sub> |
-| [protoscript](impl/protoscript) | :heavy_check_mark: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/protoscript-required.svg" height="25" width="125" /></sub><br><sup>(1084&nbsp;failures)<sub> | <sub><img src=".github/genimg/protoscript-recommended.svg" height="25" width="125" /></sub><br><sup>(529&nbsp;failures)<sub> |
-| [protoc-gen-ts](impl/protoc-gen-ts) | :x: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/protoc-gen-ts-required.svg" height="25" width="125" /></sub><br><sup>(1564&nbsp;failures)<sub> | <sub><img src=".github/genimg/protoc-gen-ts-recommended.svg" height="25" width="125" /></sub><br><sup>(466&nbsp;failures)<sub> |
+| [google-protobuf](impl/google-protobuf) | :x: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/google-protobuf-required.svg" height="25" width="125" /></sub><br><sup>(574&nbsp;failures)<sub> | <sub><img src=".github/genimg/google-protobuf-recommended.svg" height="25" width="125" /></sub><br><sup>(304&nbsp;failures)<sub> |
+| [ts-proto](impl/ts-proto) | :x: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/ts-proto-required.svg" height="25" width="125" /></sub><br><sup>(738&nbsp;failures)<sub> | <sub><img src=".github/genimg/ts-proto-recommended.svg" height="25" width="125" /></sub><br><sup>(611&nbsp;failures)<sub> |
+| [protoscript](impl/protoscript) | :heavy_check_mark: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/protoscript-required.svg" height="25" width="125" /></sub><br><sup>(1086&nbsp;failures)<sub> | <sub><img src=".github/genimg/protoscript-recommended.svg" height="25" width="125" /></sub><br><sup>(533&nbsp;failures)<sub> |
+| [protobuf.js](impl/protobuf.js) | :heavy_check_mark: | :x: | :x: | <sub><img src=".github/genimg/protobuf.js-required.svg" height="25" width="125" /></sub><br><sup>(1231&nbsp;failures)<sub> | <sub><img src=".github/genimg/protobuf.js-recommended.svg" height="25" width="125" /></sub><br><sup>(419&nbsp;failures)<sub> |
+| [protoc-gen-ts](impl/protoc-gen-ts) | :x: | :heavy_check_mark: | :x: | <sub><img src=".github/genimg/protoc-gen-ts-required.svg" height="25" width="125" /></sub><br><sup>(1566&nbsp;failures)<sub> | <sub><img src=".github/genimg/protoc-gen-ts-recommended.svg" height="25" width="125" /></sub><br><sup>(470&nbsp;failures)<sub> |
 
 <!-- TABLE-END -->
 
-Note: None of the libraries tested implement the text format so the results for those test runs are not shown.
+Since Editions are relatively new, only implementations that advertise support are tested with Editions. 
 
+Note: None of the libraries tested implement the text format, so the results for those test runs are not shown.
 
 ## Running the tests
 

impl/baseline/README.md

@@ -1,3 +1,5 @@
 # baseline
 
-A test implementation that fails all tests on purpose, so that we can collect the total numbers of tests available.
+A test implementation that fails tests on purpose, so that we can collect the total numbers of tests available.
+
+Tests for Editions are not counted, only for proto2 and proto3.

impl/baseline/buf.gen.yaml

@@ -1,7 +1,7 @@
 version: v2
 clean: true
 inputs:
-  - directory: ../../proto
+  - proto_file: ../../proto/conformance/conformance.proto
 plugins:
   - local: protoc-gen-es
     opt: target=ts

impl/baseline/failing_tests.txt

@@ -23,9 +23,11 @@ Recommended.Proto2.JsonInput.FieldNameWithDoubleUnderscores.Validator
 Recommended.Proto2.JsonInput.FloatFieldInfinityNotQuoted
 Recommended.Proto2.JsonInput.FloatFieldNanNotQuoted
 Recommended.Proto2.JsonInput.FloatFieldNegativeInfinityNotQuoted
+Recommended.Proto2.JsonInput.IgnoreUnknownEnumStringValueInMapPart.ProtobufOutput
 Recommended.Proto2.JsonInput.IgnoreUnknownEnumStringValueInMapValue.ProtobufOutput
 Recommended.Proto2.JsonInput.IgnoreUnknownEnumStringValueInOptionalField.ProtobufOutput
 Recommended.Proto2.JsonInput.IgnoreUnknownEnumStringValueInRepeatedField.ProtobufOutput
+Recommended.Proto2.JsonInput.IgnoreUnknownEnumStringValueInRepeatedPart.ProtobufOutput
 Recommended.Proto2.JsonInput.Int32MapFieldKeyNotQuoted
 Recommended.Proto2.JsonInput.Int64FieldBeString.Validator
 Recommended.Proto2.JsonInput.Int64MapFieldKeyNotQuoted
@@ -344,9 +346,11 @@ Recommended.Proto3.JsonInput.FieldNameWithDoubleUnderscores.Validator
 Recommended.Proto3.JsonInput.FloatFieldInfinityNotQuoted
 Recommended.Proto3.JsonInput.FloatFieldNanNotQuoted
 Recommended.Proto3.JsonInput.FloatFieldNegativeInfinityNotQuoted
+Recommended.Proto3.JsonInput.IgnoreUnknownEnumStringValueInMapPart.ProtobufOutput
 Recommended.Proto3.JsonInput.IgnoreUnknownEnumStringValueInMapValue.ProtobufOutput
 Recommended.Proto3.JsonInput.IgnoreUnknownEnumStringValueInOptionalField.ProtobufOutput
 Recommended.Proto3.JsonInput.IgnoreUnknownEnumStringValueInRepeatedField.ProtobufOutput
+Recommended.Proto3.JsonInput.IgnoreUnknownEnumStringValueInRepeatedPart.ProtobufOutput
 Recommended.Proto3.JsonInput.Int32MapFieldKeyNotQuoted
 Recommended.Proto3.JsonInput.Int64FieldBeString.Validator
 Recommended.Proto3.JsonInput.Int64MapFieldKeyNotQuoted
@@ -1009,6 +1013,7 @@ Required.Proto2.ProtobufInput.RepeatedScalarSelectsLast.UINT32.JsonOutput
 Required.Proto2.ProtobufInput.RepeatedScalarSelectsLast.UINT32.ProtobufOutput
 Required.Proto2.ProtobufInput.RepeatedScalarSelectsLast.UINT64.JsonOutput
 Required.Proto2.ProtobufInput.RepeatedScalarSelectsLast.UINT64.ProtobufOutput
+Required.Proto2.ProtobufInput.UnknownOrdering.ProtobufOutput
 Required.Proto2.ProtobufInput.UnknownVarint.ProtobufOutput
 Required.Proto2.ProtobufInput.ValidDataMap.BOOL.BOOL.Default.JsonOutput
 Required.Proto2.ProtobufInput.ValidDataMap.BOOL.BOOL.Default.ProtobufOutput
@@ -2054,6 +2059,7 @@ Required.Proto3.ProtobufInput.RepeatedScalarSelectsLast.UINT32.JsonOutput
 Required.Proto3.ProtobufInput.RepeatedScalarSelectsLast.UINT32.ProtobufOutput
 Required.Proto3.ProtobufInput.RepeatedScalarSelectsLast.UINT64.JsonOutput
 Required.Proto3.ProtobufInput.RepeatedScalarSelectsLast.UINT64.ProtobufOutput
+Required.Proto3.ProtobufInput.UnknownOrdering.ProtobufOutput
 Required.Proto3.ProtobufInput.UnknownVarint.ProtobufOutput
 Required.Proto3.ProtobufInput.ValidDataMap.BOOL.BOOL.Default.JsonOutput
 Required.Proto3.ProtobufInput.ValidDataMap.BOOL.BOOL.Default.ProtobufOutput

impl/baseline/failing_tests_text_format.txt

@@ -118,3 +118,12 @@ Required.Proto3.TextFormatInput.Uint32FieldTooLarge
 Required.Proto3.TextFormatInput.Uint64FieldMaxValue.ProtobufOutput
 Required.Proto3.TextFormatInput.Uint64FieldMaxValue.TextFormatOutput
 Required.Proto3.TextFormatInput.Uint64FieldTooLarge
+Required.Proto2.TextFormatInput.GroupFieldExtension.ProtobufOutput
+Required.Proto2.TextFormatInput.GroupFieldExtension.TextFormatOutput
+Required.Proto2.TextFormatInput.GroupFieldExtensionGroupName
+Required.Proto2.TextFormatInput.GroupFieldLowercased.ProtobufOutput
+Required.Proto2.TextFormatInput.GroupFieldLowercased.TextFormatOutput
+Required.Proto2.TextFormatInput.GroupFieldLowercasedMultiWord.ProtobufOutput
+Required.Proto2.TextFormatInput.GroupFieldLowercasedMultiWord.TextFormatOutput
+Required.Proto2.TextFormatInput.GroupFieldMultiWord.ProtobufOutput
+Required.Proto2.TextFormatInput.GroupFieldMultiWord.TextFormatOutput

impl/baseline/gen/conformance/conformance_pb.ts → impl/baseline/gen/conformance_pb.ts

@@ -6,18 +6,18 @@
 // https://developers.google.com/open-source/licenses/bsd
 
 // @generated by protoc-gen-es v2.0.0 with parameter "target=ts"
-// @generated from file conformance/conformance.proto (package conformance, syntax proto3)
+// @generated from file conformance.proto (package conformance, syntax proto3)
 /* eslint-disable */
 
 import type { GenEnum, GenFile, GenMessage } from "@bufbuild/protobuf/codegenv1";
 import { enumDesc, fileDesc, messageDesc } from "@bufbuild/protobuf/codegenv1";
 import type { Message } from "@bufbuild/protobuf";
 
 /**
- * Describes the file conformance/conformance.proto.
+ * Describes the file conformance.proto.
  */
-export const file_conformance_conformance: GenFile = /*@__PURE__*/
-  fileDesc("Ch1jb25mb3JtYW5jZS9jb25mb3JtYW5jZS5wcm90bxILY29uZm9ybWFuY2UiHQoKRmFpbHVyZVNldBIPCgdmYWlsdXJlGAEgAygJIuMCChJDb25mb3JtYW5jZVJlcXVlc3QSGgoQcHJvdG9idWZfcGF5bG9hZBgBIAEoDEgAEhYKDGpzb25fcGF5bG9hZBgCIAEoCUgAEhYKDGpzcGJfcGF5bG9hZBgHIAEoCUgAEhYKDHRleHRfcGF5bG9hZBgIIAEoCUgAEjgKF3JlcXVlc3RlZF9vdXRwdXRfZm9ybWF0GAMgASgOMhcuY29uZm9ybWFuY2UuV2lyZUZvcm1hdBIUCgxtZXNzYWdlX3R5cGUYBCABKAkSMAoNdGVzdF9jYXRlZ29yeRgFIAEoDjIZLmNvbmZvcm1hbmNlLlRlc3RDYXRlZ29yeRI+ChVqc3BiX2VuY29kaW5nX29wdGlvbnMYBiABKAsyHy5jb25mb3JtYW5jZS5Kc3BiRW5jb2RpbmdDb25maWcSHAoUcHJpbnRfdW5rbm93bl9maWVsZHMYCSABKAhCCQoHcGF5bG9hZCL6AQoTQ29uZm9ybWFuY2VSZXNwb25zZRIVCgtwYXJzZV9lcnJvchgBIAEoCUgAEhkKD3NlcmlhbGl6ZV9lcnJvchgGIAEoCUgAEhcKDXRpbWVvdXRfZXJyb3IYCSABKAlIABIXCg1ydW50aW1lX2Vycm9yGAIgASgJSAASGgoQcHJvdG9idWZfcGF5bG9hZBgDIAEoDEgAEhYKDGpzb25fcGF5bG9hZBgEIAEoCUgAEhEKB3NraXBwZWQYBSABKAlIABIWCgxqc3BiX3BheWxvYWQYByABKAlIABIWCgx0ZXh0X3BheWxvYWQYCCABKAlIAEIICgZyZXN1bHQiNwoSSnNwYkVuY29kaW5nQ29uZmlnEiEKGXVzZV9qc3BiX2FycmF5X2FueV9mb3JtYXQYASABKAgqUAoKV2lyZUZvcm1hdBIPCgtVTlNQRUNJRklFRBAAEgwKCFBST1RPQlVGEAESCAoESlNPThACEggKBEpTUEIQAxIPCgtURVhUX0ZPUk1BVBAEKo8BCgxUZXN0Q2F0ZWdvcnkSFAoQVU5TUEVDSUZJRURfVEVTVBAAEg8KC0JJTkFSWV9URVNUEAESDQoJSlNPTl9URVNUEAISJAogSlNPTl9JR05PUkVfVU5LTk9XTl9QQVJTSU5HX1RFU1QQAxINCglKU1BCX1RFU1QQBBIUChBURVhUX0ZPUk1BVF9URVNUEAVCLwofY29tLmdvb2dsZS5wcm90b2J1Zi5jb25mb3JtYW5jZaICC0NvbmZvcm1hbmNlYgZwcm90bzM");
+export const file_conformance: GenFile = /*@__PURE__*/
+  fileDesc("ChFjb25mb3JtYW5jZS5wcm90bxILY29uZm9ybWFuY2UiHQoKRmFpbHVyZVNldBIPCgdmYWlsdXJlGAEgAygJIuMCChJDb25mb3JtYW5jZVJlcXVlc3QSGgoQcHJvdG9idWZfcGF5bG9hZBgBIAEoDEgAEhYKDGpzb25fcGF5bG9hZBgCIAEoCUgAEhYKDGpzcGJfcGF5bG9hZBgHIAEoCUgAEhYKDHRleHRfcGF5bG9hZBgIIAEoCUgAEjgKF3JlcXVlc3RlZF9vdXRwdXRfZm9ybWF0GAMgASgOMhcuY29uZm9ybWFuY2UuV2lyZUZvcm1hdBIUCgxtZXNzYWdlX3R5cGUYBCABKAkSMAoNdGVzdF9jYXRlZ29yeRgFIAEoDjIZLmNvbmZvcm1hbmNlLlRlc3RDYXRlZ29yeRI+ChVqc3BiX2VuY29kaW5nX29wdGlvbnMYBiABKAsyHy5jb25mb3JtYW5jZS5Kc3BiRW5jb2RpbmdDb25maWcSHAoUcHJpbnRfdW5rbm93bl9maWVsZHMYCSABKAhCCQoHcGF5bG9hZCL6AQoTQ29uZm9ybWFuY2VSZXNwb25zZRIVCgtwYXJzZV9lcnJvchgBIAEoCUgAEhkKD3NlcmlhbGl6ZV9lcnJvchgGIAEoCUgAEhcKDXRpbWVvdXRfZXJyb3IYCSABKAlIABIXCg1ydW50aW1lX2Vycm9yGAIgASgJSAASGgoQcHJvdG9idWZfcGF5bG9hZBgDIAEoDEgAEhYKDGpzb25fcGF5bG9hZBgEIAEoCUgAEhEKB3NraXBwZWQYBSABKAlIABIWCgxqc3BiX3BheWxvYWQYByABKAlIABIWCgx0ZXh0X3BheWxvYWQYCCABKAlIAEIICgZyZXN1bHQiNwoSSnNwYkVuY29kaW5nQ29uZmlnEiEKGXVzZV9qc3BiX2FycmF5X2FueV9mb3JtYXQYASABKAgqUAoKV2lyZUZvcm1hdBIPCgtVTlNQRUNJRklFRBAAEgwKCFBST1RPQlVGEAESCAoESlNPThACEggKBEpTUEIQAxIPCgtURVhUX0ZPUk1BVBAEKo8BCgxUZXN0Q2F0ZWdvcnkSFAoQVU5TUEVDSUZJRURfVEVTVBAAEg8KC0JJTkFSWV9URVNUEAESDQoJSlNPTl9URVNUEAISJAogSlNPTl9JR05PUkVfVU5LTk9XTl9QQVJTSU5HX1RFU1QQAxINCglKU1BCX1RFU1QQBBIUChBURVhUX0ZPUk1BVF9URVNUEAVCLwofY29tLmdvb2dsZS5wcm90b2J1Zi5jb25mb3JtYW5jZaICC0NvbmZvcm1hbmNlYgZwcm90bzM");
 
 /**
  * The conformance runner will request a list of failures as the first request.
@@ -38,7 +38,7 @@ export type FailureSet = Message<"conformance.FailureSet"> & {
  * Use `create(FailureSetSchema)` to create a new message.
  */
 export const FailureSetSchema: GenMessage<FailureSet> = /*@__PURE__*/
-  messageDesc(file_conformance_conformance, 0);
+  messageDesc(file_conformance, 0);
 
 /**
  * Represents a single test case's input.  The testee should:
@@ -131,7 +131,7 @@ export type ConformanceRequest = Message<"conformance.ConformanceRequest"> & {
  * Use `create(ConformanceRequestSchema)` to create a new message.
  */
 export const ConformanceRequestSchema: GenMessage<ConformanceRequest> = /*@__PURE__*/
-  messageDesc(file_conformance_conformance, 1);
+  messageDesc(file_conformance, 1);
 
 /**
  * Represents a single test case's output.
@@ -238,7 +238,7 @@ export type ConformanceResponse = Message<"conformance.ConformanceResponse"> & {
  * Use `create(ConformanceResponseSchema)` to create a new message.
  */
 export const ConformanceResponseSchema: GenMessage<ConformanceResponse> = /*@__PURE__*/
-  messageDesc(file_conformance_conformance, 2);
+  messageDesc(file_conformance, 2);
 
 /**
  * Encoding options for jspb format.
@@ -259,7 +259,7 @@ export type JspbEncodingConfig = Message<"conformance.JspbEncodingConfig"> & {
  * Use `create(JspbEncodingConfigSchema)` to create a new message.
  */
 export const JspbEncodingConfigSchema: GenMessage<JspbEncodingConfig> = /*@__PURE__*/
-  messageDesc(file_conformance_conformance, 3);
+  messageDesc(file_conformance, 3);
 
 /**
  * @generated from enum conformance.WireFormat
@@ -297,7 +297,7 @@ export enum WireFormat {
  * Describes the enum conformance.WireFormat.
  */
 export const WireFormatSchema: GenEnum<WireFormat> = /*@__PURE__*/
-  enumDesc(file_conformance_conformance, 0);
+  enumDesc(file_conformance, 0);
 
 /**
  * @generated from enum conformance.TestCategory
@@ -354,5 +354,5 @@ export enum TestCategory {
  * Describes the enum conformance.TestCategory.
  */
 export const TestCategorySchema: GenEnum<TestCategory> = /*@__PURE__*/
-  enumDesc(file_conformance_conformance, 1);
+  enumDesc(file_conformance, 1);
 

impl/baseline/package.json

@@ -13,7 +13,7 @@
   "scripts": {
     "generate": "buf generate",
     "build": "tsc --noEmit",
-    "test": "conformance_test_runner --enforce_recommended --failure_list failing_tests.txt --text_format_failure_list failing_tests_text_format.txt --output_dir . runner.ts"
+    "test": "conformance_test_runner --maximum_edition PROTO3 --enforce_recommended --failure_list failing_tests.txt --text_format_failure_list failing_tests_text_format.txt --output_dir . runner.ts"
   },
   "dependencies": {
     "@bufbuild/protobuf": "^2.0.0",