Skip to content

Found new managed modules references #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Found new managed modules references #1035

merged 1 commit into from
Aug 15, 2025

Conversation

app-token-modules[bot]
Copy link
Contributor

New managed modules references found. Please review.

@app-token-modules app-token-modules bot requested a review from a team August 15, 2025 12:06
Copy link
Member

@unmultimedio unmultimedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non breaking changes afaics in WKT repo.

},
{
"name": "v32.0",
"digest": "7e2aa4fb37e2be8dc8a4bcbebaec00635abbcc7333df40ba6412a666335f66c5c0705ce4cc5c207e728412ac3d81850545f90e8535da66712a17ab42923be6bd"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd modules/sync/protocolbuffers/wellknowntypes
casdiff v31.1 v32.0 --format markdown

7 files changed: 0 removed, 0 renamed, 0 added, 7 changed content

Files changed content:

google/protobuf/api.proto:

--- shake256:202f77d21c66f1165ae72edd5ee5f8e96ee755f4ede751980ee969171b3b1105e3c08dc471b8a2709eaefb00b82c8bac2091fee872a479d2ca00fa69796a01d0  google/protobuf/api.proto
+++ shake256:bed6cb44b4bcd2fb5553d64742db714e1134a729d5a8b5b38e2335fea6eeb2125311e9d98bdaec9323d038ee17e054da737e1b8ad2173273231209f14891375e  google/protobuf/api.proto
@@ -51,6 +51,11 @@
 // sometimes simply referred to as "APIs" in other contexts, such as the name of
 // this message itself. See https://cloud.google.com/apis/design/glossary for
 // detailed terminology.
+//
+// New usages of this message as an alternative to ServiceDescriptorProto are
+// strongly discouraged. This message does not reliability preserve all
+// information necessary to model the schema and preserve semantics. Instead
+// make use of FileDescriptorSet which preserves the necessary information.
 message Api {
   // The fully qualified name of this interface, including package name
   // followed by the interface's simple name.
@@ -93,9 +98,17 @@

   // The source syntax of the service.
   Syntax syntax = 7;
+
+  // The source edition string, only valid when syntax is SYNTAX_EDITIONS.
+  string edition = 8;
 }

 // Method represents a method of an API interface.
+//
+// New usages of this message as an alternative to MethodDescriptorProto are
+// strongly discouraged. This message does not reliability preserve all
+// information necessary to model the schema and preserve semantics. Instead
+// make use of FileDescriptorSet which preserves the necessary information.
 message Method {
   // The simple name of this method.
   string name = 1;
@@ -116,7 +129,16 @@
   repeated Option options = 6;

   // The source syntax of this method.
-  Syntax syntax = 7;
+  //
+  // This field should be ignored, instead the syntax should be inherited from
+  // Api. This is similar to Field and EnumValue.
+  Syntax syntax = 7 [deprecated = true];
+
+  // The source edition string, only valid when syntax is SYNTAX_EDITIONS.
+  //
+  // This field should be ignored, instead the edition should be inherited from
+  // Api. This is similar to Field and EnumValue.
+  string edition = 8 [deprecated = true];
 }

 // Declares an API Interface to be included in this interface. The including

google/protobuf/compiler/plugin.proto:

--- shake256:a5032b15beec68adf9b22f0bc3187ff17dc3ef27b28ba8d59233ef7170f5ec4cd82e715b2029ed88f935318e9ca2c6abb6633d405ca5057a14c12d30be0ebcf5  google/protobuf/compiler/plugin.proto
+++ shake256:059f945bf1dd19f3d535b8c380cb1e2798c867820dd719ee32384f7fd635acd077d410716410646c72442f7bef4a920120af2dcddb1fb6c0e435798de4a7ba82  google/protobuf/compiler/plugin.proto
@@ -24,11 +24,11 @@
 option java_package = "com.google.protobuf.compiler";
 option java_outer_classname = "PluginProtos";

+import "google/protobuf/descriptor.proto";
+
 option csharp_namespace = "Google.Protobuf.Compiler";
 option go_package = "google.golang.org/protobuf/types/pluginpb";

-import "google/protobuf/descriptor.proto";
-
 // The version number of protocol compiler.
 message Version {
   optional int32 major = 1;

google/protobuf/cpp_features.proto:

--- shake256:0caf7a20e87c75ce2103e70c7289e78e3beb080c120672b9c64332aa04dfac14b30ef8a72e301359601a6bd3bdb977fc568ac7920446911efff4ae0f5c891f6b  google/protobuf/cpp_features.proto
+++ shake256:7e7b42c4681a54c57930d9d33422e44a91bd97fdd319042030184345a11d9b973629ab9f1145fdf198fbb3c5c7a330c7ed93ad44db3536a161bbd0e949f8d17f  google/protobuf/cpp_features.proto
@@ -55,7 +55,7 @@
   ];

   optional bool enum_name_uses_string_view = 3 [
-    retention = RETENTION_SOURCE,
+    retention = RETENTION_RUNTIME,
     targets = TARGET_TYPE_ENUM,
     targets = TARGET_TYPE_FILE,
     feature_support = {

google/protobuf/descriptor.proto:

--- shake256:ca03f1491ea87444d08ec204dade77abd89abe9237211f0bb5ec80501be3b6ce39d0f1017790742c5b6f6345b38a56ba779fab544bad1c3fc951254295cdf574  google/protobuf/descriptor.proto
+++ shake256:2b6fb491b5832e4c381224372998dc7bfae2cb557c40e5132884c1eef68b31570ed1d2b902fde0cf19739dfc5140f79dc628be40f268c523c3e5a923038fa8e1  google/protobuf/descriptor.proto
@@ -753,8 +753,9 @@
   // is a formalization for deprecating fields.
   optional bool deprecated = 3 [default = false];

+  // DEPRECATED. DO NOT USE!
   // For Google-internal migration only. Do not use.
-  optional bool weak = 10 [default = false];
+  optional bool weak = 10 [default = false, deprecated = true];

   // Indicate that the field value should not be printed out when using debug
   // formats, e.g. when the field contains sensitive credentials.
@@ -1180,6 +1181,11 @@
       number: 1003,
       full_name: ".pb.python",
       type: ".pb.PythonFeatures"
+    },
+    declaration = {
+      number: 9989,
+      full_name: ".pb.java_mutable",
+      type: ".pb.JavaMutableFeatures"
     },
     declaration = {
       number: 9990,

google/protobuf/go_features.proto:

--- shake256:303fac34a6c093ddcceffeb6179ac8bf999b91daa3c8cecc283782cc3199a723dd42a6cea38a503163fab42a62ec7cf767b942c212de08d35577c858132f3068  google/protobuf/go_features.proto
+++ shake256:da1dc4060f405ccda4033e045769b64c29d39b2fa0acd8a17800f371e9df6761a5f4fb09ae3a17b2457724c29177cf8b92849f3faba00522bd693c734ddd4340  google/protobuf/go_features.proto
@@ -52,9 +52,12 @@
     feature_support = {
       edition_introduced: EDITION_2023,
     },
-    edition_defaults = { edition: EDITION_LEGACY, value: "API_LEVEL_UNSPECIFIED" },
+    edition_defaults = {
+      edition: EDITION_LEGACY,
+      value: "API_LEVEL_UNSPECIFIED"
+    },
     edition_defaults = { edition: EDITION_2024, value: "API_OPAQUE" }
-   ];
+  ];

   enum StripEnumPrefix {
     STRIP_ENUM_PREFIX_UNSPECIFIED = 0;

google/protobuf/java_features.proto:

--- shake256:b7b02d2c0f9134c09931019bb13d1bc6d780d445ccc53efb6dfb25b0a21ed3788e2bde347b897f1f08516c8c4e6ba8c70c09005041d86e96f0043c68601b4459  google/protobuf/java_features.proto
+++ shake256:062035772c41937d8709c37cc101d9a6d197f0c64ee53e6db6fdd421faf47d7ce30ad78f9413deef4c66943a69811443790f52c2d213abd8fb501e1dadd555c6  google/protobuf/java_features.proto
@@ -117,7 +117,7 @@
   // Whether to nest the generated class in the generated file class. This is
   // only applicable to *top-level* messages, enums, and services.
   optional NestInFileClassFeature.NestInFileClass nest_in_file_class = 5 [
-    retention = RETENTION_SOURCE,
+    retention = RETENTION_RUNTIME,
     targets = TARGET_TYPE_MESSAGE,
     targets = TARGET_TYPE_ENUM,
     targets = TARGET_TYPE_SERVICE,
@@ -127,4 +127,6 @@
     edition_defaults = { edition: EDITION_LEGACY, value: "LEGACY" },
     edition_defaults = { edition: EDITION_2024, value: "NO" }
   ];
+
+  reserved 6;  // field `mutable_nest_in_file_class` removed.
 }

google/protobuf/type.proto:

--- shake256:32bdc6bbb5e798425b15594f917e79b11608cfac63c9a3621848b217e4bee3a62018860ef41da5e16ee82995c5d13de3459f61d1b295fb4c6fe79cb164521d90  google/protobuf/type.proto
+++ shake256:3f84f0f8298ff02f92800f4aa6819cf5eb39065940089748cda71c03c279d40249c1a02f239057300ac862b06682f5e748d20f42adcb8621f941cc5c71155947  google/protobuf/type.proto
@@ -44,6 +44,11 @@
 option go_package = "google.golang.org/protobuf/types/known/typepb";

 // A protocol buffer message type.
+//
+// New usages of this message as an alternative to DescriptorProto are strongly
+// discouraged. This message does not reliability preserve all information
+// necessary to model the schema and preserve semantics. Instead make use of
+// FileDescriptorSet which preserves the necessary information.
 message Type {
   // The fully qualified message name.
   string name = 1;
@@ -62,6 +67,11 @@
 }

 // A single field of a message type.
+//
+// New usages of this message as an alternative to FieldDescriptorProto are
+// strongly discouraged. This message does not reliability preserve all
+// information necessary to model the schema and preserve semantics. Instead
+// make use of FileDescriptorSet which preserves the necessary information.
 message Field {
   // Basic field types.
   enum Kind {
@@ -142,6 +152,11 @@
 }

 // Enum type definition.
+//
+// New usages of this message as an alternative to EnumDescriptorProto are
+// strongly discouraged. This message does not reliability preserve all
+// information necessary to model the schema and preserve semantics. Instead
+// make use of FileDescriptorSet which preserves the necessary information.
 message Enum {
   // Enum type name.
   string name = 1;
@@ -158,6 +173,11 @@
 }

 // Enum value definition.
+//
+// New usages of this message as an alternative to EnumValueDescriptorProto are
+// strongly discouraged. This message does not reliability preserve all
+// information necessary to model the schema and preserve semantics. Instead
+// make use of FileDescriptorSet which preserves the necessary information.
 message EnumValue {
   // Enum value name.
   string name = 1;
@@ -169,6 +189,10 @@

 // A protocol buffer option, which can be attached to a message, field,
 // enumeration, etc.
+//
+// New usages of this message as an alternative to FileOptions, MessageOptions,
+// FieldOptions, EnumOptions, EnumValueOptions, ServiceOptions, or MethodOptions
+// are strongly discouraged.
 message Option {
   // The option's name. For protobuf built-in options (options defined in
   // descriptor.proto), this is the short name. For example, `"map_entry"`.

@unmultimedio unmultimedio merged commit 26a7b26 into main Aug 15, 2025
5 checks passed
@unmultimedio unmultimedio deleted the fetch-modules branch August 15, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant