Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable exclude-path on breaking, build, export, and lint #713

Merged
merged 7 commits into from
Nov 10, 2021
Merged

Enable exclude-path on breaking, build, export, and lint #713

merged 7 commits into from
Nov 10, 2021

Conversation

doriable
Copy link
Member

@doriable doriable commented Nov 9, 2021

#689 Added support for exclude-path to buf generate by enabling our module and image build paths to support exclude paths. This turns that functionality on for the rest of the commands that also supported --path.

Reference: #224

@doriable doriable marked this pull request as ready for review November 9, 2021 21:27
amckinney
amckinney approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@doriable doriable merged commit 234968f into main Nov 10, 2021
@doriable doriable deleted the add-exclude-path-to-all-commands branch November 10, 2021 16:55
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
@doriable
Enable exclude-path on breaking, build, export, and lint (b…
4a17ce4 
…ufbuild#713)

* Enable `exclude-path` on `breaking`, `build`, `export`, and `lint`

* Add tests.

* Add changelog entry.

* Add a test for `buf breaking`.

* For images, the normalised path for breaking change errors is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doriable @amckinney