Add number of deprecated types to protostat #4300
Merged
+316
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
cyinma
commented
Jan 23, 2026
Comment on lines
+98
to
+107
| name: "outer deprecated but nested not", | ||
| content: ` | ||
| syntax = "proto3"; | ||
| message Outer { | ||
| option deprecated = true; | ||
| message Inner {} | ||
| } | ||
| `, | ||
| expectedTypes: 2, | ||
| expectedDeprecatedTypes: 1, |
Member
Author
There was a problem hiding this comment.
This might be the most ambiguous case, but I think each nested type should be marked as deprecated explicitly in order to be considered deprecated
stefanvanburen
approved these changes
Jan 26, 2026
emcfarlane
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.