-
Notifications
You must be signed in to change notification settings - Fork 7
feat(browser-sdk,react-sdk): check events #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for tracking rule evaluation results and missing context fields - Extend `CheckEvent` and `FetchedFeature` types to include additional metadata - Update client-side event sending to include more detailed feature flag information
- Add `action` field to distinguish between feature flag and config check events - Include rule evaluation results and missing context fields in check events - Update test cases to reflect new event tracking capabilities
- Update `useFeature` hook to use client's `getFeature` method - Remove redundant feature tracking logic - Simplify feature flag and configuration access - Add null check for client to prevent potential errors
…valuation details - Add support for new feature flag event actions: "check-config" and "evaluate-config" - Extend event tracking to include more detailed evaluation metadata - Update types to support richer feature flag and configuration event information - Improve logging and tracking of missing context fields - Enhance client-side event sending with comprehensive feature flag details
- Add `ruleEvaluationResults` and `missingContextFields` to feature flag variant details - Update client to expose more comprehensive feature flag evaluation information - Enhance test cases to reflect new response structure with evaluation metadata
…nd error handling - Optimize event tracking by using Promise.allSettled for concurrent event sending - Flatten and collect promises to handle multiple event tracking scenarios - Improve error logging for failed event tracking attempts - Update test cases to reflect new event tracking approach
- Refactor `warnMissingFeatureContextFields` to use a more efficient reporting approach - Consolidate missing context field warnings into a single log message - Add support for tracking missing fields for both features and their configurations - Update rate limiting to prevent duplicate warnings - Enhance logging with a comprehensive report of missing context fields
…fields - Implement `warnMissingFeatureContextFields` method to log context field warnings - Update rate-limited logging for missing context fields - Modify `sendCheckEvent` to prefix rate limit key for better tracking - Update test logger to use vitest mock functions - Add test case for missing context fields warning mechanism
…nd usage patterns - Update README for browser and node SDKs with comprehensive feature documentation - Add sections on feature overrides, error handling, and advanced configuration - Improve TypeScript type examples and usage guidance - Include detailed explanations for batch operations, rate limiting, and caching - Enhance documentation formatting and readability
…tting across SDKs - Update markdown files with consistent formatting and improved readability - Convert notes to GitHub-style blockquotes - Enhance code examples with TypeScript syntax highlighting - Improve documentation structure and clarity - Add more detailed explanations for SDK configuration and usage
…ature configurations - Remove `default` property from feature configuration types - Update client implementations to exclude `default` flag in feature and variant objects - Bump SDK versions to reflect breaking type changes - Synchronize version updates across browser, node, and react SDKs
- Update docs.sh script to process markdown files more comprehensively - Add support for converting GitHub-style NOTE, WARNING, and DANGER blocks to GitBook hints - Improve file processing with more robust handling of markdown files - Fix anchor link generation in globals.md files
…quotes - Convert documentation hints to GitHub-style blockquotes - Update README with new blockquote styles for NOTE, TIP, IMPORTANT, WARNING, and CAUTION - Improve documentation readability and consistency with markdown formatting
roncohen
pushed a commit
that referenced
this pull request
Feb 26, 2025
roncohen
pushed a commit
that referenced
this pull request
Feb 26, 2025
roncohen
pushed a commit
that referenced
this pull request
Feb 26, 2025
roncohen
pushed a commit
that referenced
this pull request
Feb 26, 2025
roncohen
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.