Skip to content

fix(node-sdk): ensure timers don't keep process alive #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

roncohen
Copy link
Contributor

@roncohen roncohen commented Feb 3, 2025

Unable to write a test for this, but tested manually.

@roncohen roncohen changed the title fix: ensure timers don't keep process alive fix(node-sdk): ensure timers don't keep process alive Feb 3, 2025
@roncohen roncohen requested a review from pavkam February 3, 2025 20:18
@roncohen roncohen changed the base branch from main to 1.5 February 3, 2025 20:19
@roncohen roncohen force-pushed the fix-ensure-timers-dont-keep-process-alive branch from bfc7ab3 to c03057a Compare February 3, 2025 20:20
@roncohen roncohen merged commit ed21116 into 1.5 Feb 3, 2025
6 checks passed
@roncohen roncohen deleted the fix-ensure-timers-dont-keep-process-alive branch February 3, 2025 20:21
roncohen added a commit that referenced this pull request Feb 4, 2025
Unable to write a test for this, but tested manually.
roncohen added a commit that referenced this pull request Feb 26, 2025
Unable to write a test for this, but tested manually.
roncohen added a commit that referenced this pull request Feb 26, 2025
Unable to write a test for this, but tested manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants