Build fails on perl 5.34

[ptribble]

Attempting to build 3.19.0 on a system with perl 5.34 fails with

ExtUtils::MakeMaker version 7.64 required--this is only version 7.62 at Makefile.PL line 1.
BEGIN failed--compilation aborted at Makefile.PL line 1.

Given that ExtUtils::MakeMaker is part of perl itself, it can't be updated, so this means I'm unable to update DBD::Pg

(Appears to be fallout from #155 )

[esabol]

Given that ExtUtils::MakeMaker is part of perl itself, it can't be updated

That's not true. I update ExtUtils::MakeMaker on older Perls all the time.

But if you don't want to do so, you can just remove the version number requirement in Makefile.PL, and it'll work in most cases.

[ptribble]

That's not true. I update ExtUtils::MakeMaker on older Perls all the time.

How is that done when perl is supplied as an OS package and owned by root?

[esabol]

Well, I would install ExtUtils::MakeMaker somewhere I can write to, like under my home directory, and then set PERL5LIB accordingly.

[esabol]

Just for the record, this is actually fallout from issue #69 and PR #137. PR #155 was just cleaning up that change.

[turnstep]

Ugh, well this is not good. I think we should revisit the 7.64 requirement. Maybe we can require a lower version of ExtUtils::MakeMaker but have Makefile.PL check the version if $^O says we are a mac?

[turnstep]

I was thinking something simple like this:

diff --git a/Makefile.PL b/Makefile.PL
index 2e500e6..6cd0597 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -1,4 +1,4 @@
-use ExtUtils::MakeMaker 7.64;
+use ExtUtils::MakeMaker;
 use Config;
 use strict;
 use warnings;
@@ -26,6 +26,11 @@ BEGIN {

 use lib $lib;

+if ($^O eq 'MacOS' and $ExtUtils::MakeMaker::VERSION > 7.64) {
+    warn "You may need ExtUtils::MakeMaker version 7.64 to compile on MacOS\n";
+}
+
+
 if ($VERSION =~ /_/) {
     print "WARNING! This is a test version ($VERSION) and should not be used in production!\n";
 }
@@ -221,7 +226,7 @@ my %opts =
      AUTHOR         => 'Greg Sabino Mullane',
      ABSTRACT       => 'PostgreSQL database driver for the DBI module',
      PREREQ_PM      => {
-                        'ExtUtils::MakeMaker' => '7.64',
+                        'ExtUtils::MakeMaker' => ($^O eq 'MacOS' ? '7.64' : '6.58'),
                         'DBI'                 => '1.614',
                         'File::Temp'          => '0',
                         'Test::More'          => '0.88',

Not ideal, but I don't think there is a smooth way to truly have both exist.

[esabol]

+if ($^O eq 'MacOS' and $ExtUtils::MakeMaker::VERSION > 7.64) {

Should be < there, of course. And $^O is darwin on my Mac.

META.yml and META.json would also need to be changed. I'd put ExtUtils::MakeMaker : 7.64 under recommends.

It's too late for 3.20.0, unfortunately, but I don't have a strong objection to this approach.

[turnstep]

What do you think about the ternary test in the patch above? Keep as is, or just use separate require and recommends like this version (attached)?

dbdpg_osx_extutils.patch

[esabol]

@turnstep asked:

What do you think about the ternary test in the patch above? Keep as is, or just use separate require and recommends like this version (attached)?

If you're going to print a warning message in Makefile.PL, then the ternary test under PREREQ_PM makes it a fatal error, right? It should be either a warning or a fatal error. It shouldn't be both. I'd probably leave out the ternary test under PREREQ_PM.

I'm not actually sure what recommends does, tbh, but it seems logical. Will cpan or cpanm prompt you to upgrade ExtUtils::MakeMaker if your version is less than 7.64 or just ignore it?

dbdpg_osx_extutils.patch

That patch has an error:

if ($^O eq 'MacOS' or $^O eq 'Darwin' and $emmv < 7.64) {

needs to be

if ($^O eq 'darwin' and $emmv < 7.64) {

Lowercase darwin and $^O is never MacOS even on the latest macOS 26. (I double-checked this on 3 different major versions of macOS on both Intel and Apple Silicon).

[turnstep]

Hmm we have MacOS earlier in the file, so at some point it was that. I'll fix the caps though. I am not sure what 'recommends' does exactly either, but as you say, it sounds correct. :)

dbdpg_osx_extutils.2.patch

[esabol]

Hmm we have MacOS earlier in the file, so at some point it was that.

The colon in %seplist for MacOS would seem to indicate that that might have been in the pre-Mac OS X era (pre-2001). MacPerl was an implementation of Perl that ran on the now-retro Mac System 7.x/8.x. In any case, I doubt the shared library shenanigans that ExtUtils::MakeMaker 7.64+ do would apply to those ancient operating systems. Whatever. It doesn't really matter. 😄