Repository navigation
Fade the CD fader from the current level - #35
Merged
Merged
Conversation
Port 0x98 bit 2 started a fade from the opposite end, so the 5 the CD BIOS's player writes right after starting a track (0x3496) dropped to silence and faded in over two seconds, cutting off the start of every track it played. Fading from the current level leaves the player's 0-then-5 at full volume and still fades Mirrors back in after its 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port 0x98 bit 2 started a fade from the opposite end, so the
5the CD BIOS's player writes right after starting a track (0x3496, after0at 0x3417, D8 and D9) dropped the level to silence and faded it in over two seconds, cutting off the start of every track the player played (Mirrors' track 1 opens at full level 1.2 s in).A fade now starts from the current level. The player's
0-then-5stays at full volume; Mirrors'7→ stop → next track →5still fades back in from silence. Neither reading has been checked on real hardware; this one fits every write seen.swift test: 1046 passedscripts/regression_compare.py): 20 PASS🤖 Generated with Claude Code