Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply kraken api changelog until mar 27 2023 #40

Merged
merged 9 commits into from
Mar 27, 2023

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Mar 27, 2023

Summary

  • Added create_subaccount endpoint to kraken.spot.client.User(only for institutional clients).
  • get_recend_deposits_status and get_recend_withdraw_status in kraken.spot.client.Funding do not require the asset parameter anymore.
  • The reduce_only parameter was added to the kraken.spot.client.Trade.create_order method.
  • The consolidate_trades parameter was added to kraken.spot.client.User.get_orders_info

Closes #36
Closes #37
Closes #38
Closes #39

@btschwertfeger btschwertfeger self-assigned this Mar 27, 2023
@btschwertfeger btschwertfeger added this to the Release v1.0.1 milestone Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.55 ⚠️

Comparison is base (d704478) 85.76% compared to head (c3be527) 85.22%.

❗ Current head c3be527 differs from pull request most recent head 60ccaca. Consider uploading reports for the commit 60ccaca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   85.76%   85.22%   -0.55%     
==========================================
  Files          17       17              
  Lines        1335     1340       +5     
==========================================
- Hits         1145     1142       -3     
- Misses        190      198       +8     
Flag Coverage Δ
unittests 85.22% <75.00%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kraken/spot/trade/trade.py 91.04% <ø> (ø)
kraken/spot/funding/funding.py 65.51% <62.50%> (-30.49%) ⬇️
kraken/spot/user/user.py 96.19% <100.00%> (+1.04%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@btschwertfeger btschwertfeger added Bug Something isn't working Should Something that should be implemented somewhere in the future labels Mar 27, 2023
@btschwertfeger btschwertfeger marked this pull request as ready for review March 27, 2023 19:37
@btschwertfeger btschwertfeger merged commit 4a378a1 into master Mar 27, 2023
@btschwertfeger btschwertfeger deleted the apply-kraken-api-changelog-until-mar-27-2023 branch March 27, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Should Something that should be implemented somewhere in the future
Projects
None yet
1 participant