Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project settings #283

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Update project settings #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc8cce9
Update project settings
btschwertfeger Sep 24, 2024
d28eacc
remove secret passing in cicd.yaml
btschwertfeger Sep 24, 2024
e07ed70
apply ruff
btschwertfeger Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/_pypi_publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ name: PyPI Publish

on:
workflow_call:
secrets:
API_TOKEN:
required: true

permissions: read-all

Expand Down Expand Up @@ -40,5 +37,4 @@ jobs:
- name: Publish package distributions to PyPI (optional - testpypi)
uses: pypa/gh-action-pypi-publish@897895f1e160c830e369f9779632ebc134688e1b # release/v1
with:
password: ${{ secrets.API_TOKEN }}
repository-url: https://upload.pypi.org/legacy/
4 changes: 0 additions & 4 deletions .github/workflows/_pypi_test_publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ name: PyPI Publish

on:
workflow_call:
secrets:
API_TOKEN:
required: true

permissions: read-all

Expand Down Expand Up @@ -40,5 +37,4 @@ jobs:
- name: Publish package distributions to PyPI (optional - testpypi)
uses: pypa/gh-action-pypi-publish@897895f1e160c830e369f9779632ebc134688e1b # release/v1
with:
password: ${{ secrets.API_TOKEN }}
repository-url: https://test.pypi.org/legacy/
4 changes: 0 additions & 4 deletions .github/workflows/cicd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,6 @@ jobs:
- CodeCov
name: Upload development version to Test PyPI
uses: ./.github/workflows/_pypi_test_publish.yaml
secrets:
API_TOKEN: ${{ secrets.TEST_PYPI_API_TOKEN }}

## ===========================================================================
## Upload the python-kraken-sdk to Production PyPI
Expand All @@ -253,5 +251,3 @@ jobs:
- CodeCov
name: Upload release to PyPI
uses: ./.github/workflows/_pypi_publish.yaml
secrets:
API_TOKEN: ${{ secrets.PYPI_API_TOKEN }}
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.6.4
rev: v0.6.7
hooks:
- id: ruff
args:
Expand All @@ -32,7 +32,7 @@ repos:
- --install-types
- --non-interactive
- repo: https://github.com/gitleaks/gitleaks
rev: v8.18.4
rev: v8.19.2
hooks:
- id: gitleaks
- repo: https://github.com/codespell-project/codespell
Expand Down Expand Up @@ -88,12 +88,12 @@ repos:
args:
- --profile=black
- repo: https://github.com/PyCQA/bandit
rev: 1.7.0
rev: 1.7.10
hooks:
- id: bandit
exclude: "^tests/.*|examples/.*"
- repo: https://github.com/yunojuno/pre-commit-xenon
rev: cc59b0431a5d072786b59430e9b342b2881064f6
rev: v0.1
hooks:
- id: xenon
args:
Expand Down
3 changes: 1 addition & 2 deletions kraken/base_api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,8 +870,7 @@ def _get_kraken_futures_signature(
:return: The signed string
:rtype: str
"""
if endpoint.startswith("/derivatives"):
endpoint = endpoint[len("/derivatives") :]
endpoint = endpoint.removeprefix("/derivatives")

sha256_hash = hashlib.sha256()
sha256_hash.update((data + nonce + endpoint).encode("utf8"))
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ dependencies = [
]
keywords = ["crypto", "trading", "kraken", "exchange", "api"]
classifiers = [
"License :: OSI Approved :: GNU General Public License v3 (GPLv3)",
"License :: OSI Approved :: Apache Software License",
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Developers",
"Topic :: Office/Business :: Financial",
"Topic :: Office/Business :: Financial :: Investment",
"Topic :: Software Development :: Libraries :: Python Modules",
"Topic :: Internet :: WWW/HTTP",
"Topic :: Utilities",
Expand Down
Loading