Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot access private historical events of the Futures Market client #62

Closed
btschwertfeger opened this issue Apr 4, 2023 · 0 comments · Fixed by #61
Closed

Cannot access private historical events of the Futures Market client #62

btschwertfeger opened this issue Apr 4, 2023 · 0 comments · Fixed by #61
Assignees
@btschwertfeger
Labels
Bug Something isn't working Futures Topic related to Futures trading Must This is a must
Milestone
v1.1.0

Comments

@btschwertfeger
Copy link
Owner

Describe the bug (python-kraken-sdk==v1.0.1)
When using any endpoint listed in the futures Market client like get_execution_events and get_order_events I cannot use the parameters since within the _get_historical_events method of the futures Market client there is a GET request, but passing post_params. This should be changed to query_params.
@btschwertfeger btschwertfeger added Bug Something isn't working Must This is a must labels Apr 4, 2023
@btschwertfeger btschwertfeger added this to the v1.1.0 milestone Apr 4, 2023
@btschwertfeger btschwertfeger self-assigned this Apr 4, 2023
@btschwertfeger btschwertfeger mentioned this issue Apr 4, 2023
Merged
btschwertfeger added a commit that referenced this issue Apr 4, 2023
@btschwertfeger
fixed Issue #62; extended docstrings
60e88ff
@btschwertfeger btschwertfeger added the Futures Topic related to Futures trading label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btschwertfeger btschwertfeger

Labels
Bug Something isn't working Futures Topic related to Futures trading Must This is a must
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Prepare Release v1.1.0 btschwertfeger/python-kraken-sdk
1 participant
@btschwertfeger