-
Notifications
You must be signed in to change notification settings - Fork 2
Resolve "Kraken messes with vol_exec"
#73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 83.75% 83.70% -0.05%
==========================================
Files 25 25
Lines 1674 1682 +8
==========================================
+ Hits 1402 1408 +6
- Misses 272 274 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🚀 Deployment StatusRelease Name: The infinity-grid application has been deployed to the Kubernetes cluster using the PR-specific Docker image. Commands to check the deployment: kubectl get pods -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl logs -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl describe deployment -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73The deployment will be automatically cleaned up when this PR is closed. |
🚀 Deployment StatusRelease Name: The infinity-grid application has been deployed to the Kubernetes cluster using the PR-specific Docker image. Commands to check the deployment: kubectl get pods -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl logs -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl describe deployment -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73The deployment will be automatically cleaned up when this PR is closed. |
🚀 Deployment StatusRelease Name: The infinity-grid application has been deployed to the Kubernetes cluster using the PR-specific Docker image. Commands to check the deployment: kubectl get pods -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl logs -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl describe deployment -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73The deployment will be automatically cleaned up when this PR is closed. |
🚀 Deployment StatusRelease Name: The infinity-grid application has been deployed to the Kubernetes cluster using the PR-specific Docker image. Commands to check the deployment: kubectl get pods -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl logs -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73
kubectl describe deployment -n infinity-grid -l app.kubernetes.io/instance=infinity-grid-pr-73The deployment will be automatically cleaned up when this PR is closed. |
🧹 Cleanup CompleteRelease Name: The following resources have been cleaned up:
The infrastructure for this PR has been fully cleaned up. |
The problem described in the issue is a hard one. The error must be on the side of Kraken, since the balance retrieved via REST API (without further processing) does not match with the expectations based on the
vol_execvalue, meaning that even if an order with a fixed volume like 0.01205356 is being executed, there is a chance that Kraken will only add 0.012053559999999998 to the accounts' balances (and yes, the fee was paid with the quote and not with base currency).Meaning that we have the following alternatives:
min(vol_exec, <available base balance>)- this is quite unsafe, since the case where the user might messed up with the volumes, e.g. by trading by hand, would lead to situations where actual errors with the balance would not be visible. Also it might be the case that then orders are created that are way too small in terms of volume.Closes #72