Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored BTraceEngine listeners to an appropriate class #361

Conversation

refactormachine
Copy link
Contributor

@refactormachine refactormachine commented Aug 23, 2018

BTraceEngine need to handle the listeners by himself, we have refactored the code to have the listeners be handled by another class.
We moved a few methods to a new separate class.

We created this refactoring using automatic tools. See our website
www.refactormachine.com


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@040424c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #361   +/-   ##
=========================================
  Coverage          ?   29.65%           
  Complexity        ?     1184           
=========================================
  Files             ?      157           
  Lines             ?    15143           
  Branches          ?     2526           
=========================================
  Hits              ?     4491           
  Misses            ?    10047           
  Partials          ?      605
Impacted Files Coverage Δ Complexity Δ
...sses/com/sun/btrace/api/impl/BTraceEngineImpl.java 0% <0%> (ø) 0 <0> (?)
...com/sun/btrace/api/impl/BTraceEngineListeners.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040424c...9d835c7. Read the comment docs.

Copy link
Collaborator

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jbachorik jbachorik merged commit b60f38f into btraceio:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants