walletdb: revert bolt v1.3.4 #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v1.3.4 version of the bolt module contained a bug fix to allow the use of go1.14, but it uncovered a GC issue.
Roasbeef
reviewed
Apr 3, 2020
| @@ -9,7 +9,7 @@ import ( | |||
| "os" | |||
|
|
|||
| "github.com/btcsuite/btcwallet/walletdb" | |||
| "go.etcd.io/bbolt" | |||
| "github.com/coreos/bbolt" | |||
There was a problem hiding this comment.
I think this needs to be the other path?
There was a problem hiding this comment.
I reverted the commit this time and this was part of it. Seems to build just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting until etcd-io/bbolt#214 is resolved.