Skip to content

Commit

Permalink
Fix ratelimiter usage (#30015)
Browse files Browse the repository at this point in the history
GitOrigin-RevId: 4a47ea43bf579415b7b88b2b4cc7eace417bbc07
  • Loading branch information
gautamg795 authored and Convex, Inc. committed Sep 20, 2024
1 parent 23bb671 commit cffa68d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions crates/common/src/persistence.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,6 @@ pub trait Persistence: Sync + Send + 'static {

fn reader(&self) -> Arc<dyn PersistenceReader>;

fn set_ratelimiter_enabled(&self, enabled: bool);

/// Writes documents and the respective derived indexes.
async fn write(
&self,
Expand Down
2 changes: 0 additions & 2 deletions crates/common/src/testing/test_persistence.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ impl Persistence for TestPersistence {
Arc::new(self.clone())
}

fn set_ratelimiter_enabled(&self, _: bool) {}

async fn write(
&self,
documents: Vec<(Timestamp, InternalDocumentId, Option<ResolvedDocument>)>,
Expand Down
4 changes: 0 additions & 4 deletions crates/sqlite/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,6 @@ impl Persistence for SqlitePersistence {
})
}

fn set_ratelimiter_enabled(&self, _: bool) {
// rate limiting is not implemented for SqlitePersistence
}

async fn write(
&self,
documents: Vec<(Timestamp, InternalDocumentId, Option<ResolvedDocument>)>,
Expand Down

0 comments on commit cffa68d

Please sign in to comment.