Use ToLowerInvariant instead of ToLower #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luludotdev
approved these changes
May 18, 2021
Meivyn
added a commit
to Meivyn/ModAssistant
that referenced
this pull request
Dec 2, 2021
luludotdev
pushed a commit
that referenced
this pull request
Dec 23, 2021
kcrg
pushed a commit
to kcrg/ModAssistant
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to become crazy due to this, on some cultures BSIPA ends into
IPA\Pendingdue tomod.name.ToLower() == "bsipa"not correctly matching. See https://stackoverflow.com/a/19778131 for details.We replace all
ToLowertoToLowerInvariantto prevent future similar hair-pulling issues.