Skip to content

Fix docs path and build #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2019
Merged

Fix docs path and build #668

merged 2 commits into from
Feb 21, 2019

Conversation

gronke
Copy link
Member

@gronke gronke commented Feb 21, 2019

  • The paths configured in Sphinx were updated form ioc to libioc
  • Circular dependency between BaseConfig / Defaults resolved

@gronke gronke added the chore label Feb 21, 2019
@gronke
resolve circular dependency in BaseConfig
95359b8 
fixes an issue building the sphinx docs
@gronke gronke force-pushed the chore/fix-version-in-docs branch from 18d1496 to 95359b8 Compare February 21, 2019 15:19
igalic
igalic approved these changes Feb 21, 2019
View reviewed changes
Copy link
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@gronke gronke merged commit 95359b8 into master Feb 21, 2019
@gronke gronke deleted the chore/fix-version-in-docs branch February 21, 2019 15:50
@gronke
Copy link
Member Author

gronke commented Feb 21, 2019

https://bsdci.github.io/libioc/index.html updated

@himrock922 himrock922 mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gronke @igalic