Unhide shared ZFS zvol devices #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gronke
force-pushed
the
enhancement/shared-zfs-unhide-zvol
branch
from
4135694 to
bd02a81
Compare
igalic
reviewed
Feb 8, 2019
| @@ -58,23 +59,23 @@ def umount_zfs_shares(self) -> None: | |||
| "/sbin/zfs", | |||
| "set", | |||
| "jailed=off", | |||
| dataset.name | |||
| shlex.quote(dataset.name) | |||
| ]) | |||
| self._exec([ | |||
| "/sbin/zfs", | |||
| "umount", | |||
There was a problem hiding this comment.
i'm surprised we're not doing this with libzfs
| @@ -1603,6 +1609,25 @@ def devfs_ruleset(self) -> libioc.DevfsRules.DevfsRuleset: | |||
| if self._allow_mount_zfs == "1": | |||
| devfs_ruleset.append("add path zfs unhide") | |||
|
|
|||
| if self.config["jail_zfs"] is True: | |||
There was a problem hiding this comment.
do i understand the PR correctly that this can be both, a zfs dataset or a zvol?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ZFS datasets are shared with a jail, their according zvol dev volumes should also appear in the jail.
For instance this is required when following the article on VMs in jails by @lattera.