Trees Module

[gcasadesus]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue_number)

Type of change

Please delete options that are not relevant.

• New algorithm or support class.
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. If you haven't added any test and it is relevant provide instructions so we can reproduce.

• I have added a new test file: [E.g. test_rf.py]
• I have added a new test case: [E.g. RFTest.test_make_classification]
• I have tested it manually in a local environment.
• I have tested it manually in a supercomputer.

Reproduce instructions:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas.
• I have documented the public methods of any public class according to the guide styles.
• I have made corresponding changes to the documentation
• New and existing unit tests pass locally with my changes
• I have rebased my branch before trying to merge.

[codecov]

Codecov Report

Merging #351 (1ddfeed) into master (8b34f9c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files          38       39    +1     
  Lines        4001     4004    +3     
=======================================
+ Hits         3912     3915    +3     
  Misses         89       89           

Impacted Files	Coverage Δ
dislib/trees/test_split.py	100.00% <ø> (ø)
dislib/classification/__init__.py	100.00% <100.00%> (ø)
dislib/regression/__init__.py	100.00% <100.00%> (ø)
dislib/trees/__init__.py	100.00% <100.00%> (ø)
dislib/trees/data.py	98.73% <100.00%> (ø)
dislib/trees/decision_tree.py	99.00% <100.00%> (ø)
dislib/trees/forest.py	97.76% <100.00%> (ø)
dislib/utils/saving.py	98.61% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b34f9c...1ddfeed. Read the comment docs.

[michal-choinski]

This small change would be nice (not exposing "private" objects of the module)

[michal-choinski]

please consider exposing only objects that are necessary in dislib/regression/init.py
(currently all of them are exposed)

[michal-choinski]

please consider exposing only objects that are necessary in dislib/regression/init.py
(currently all of them are exposed)

[michal-choinski]

please consider exposing only objects that are necessary in dislib/regression/init.py
(currently all of them are exposed)