-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save models and RandomForestRegressor #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjconejero
previously approved these changes
Jul 19, 2021
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 95.95% 97.77% +1.81%
==========================================
Files 37 38 +1
Lines 3759 4001 +242
==========================================
+ Hits 3607 3912 +305
+ Misses 152 89 -63
Continue to review full report at Codecov.
|
gcasadesus
changed the title
Save models and RF Regressor
Save models and RandomForestRegressor
Jul 27, 2021
fjconejero
previously approved these changes
Aug 2, 2021
fjconejero
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides methods regarding the saving and loading of models using JSON and CBOR format.
save_model
: Saves a serialized object to disk. This function uses the json and cbor2 utilities for serialization. Models, ds-arrays, and dictionaries of all kinds of objects can be saved using this function.load_model
: Uses a custom decoder to deserialize saved object files to memory.Implemented RandomForestRegressor by modifying the already existing RandomForestClassifier. Mainly changed
Creation of a
commons
module that includes code used in multiple tasks to improve code maintainability. Following the already existing naming conventions, therf
submodule has been created with the classes regarding Random Forests and Decision Trees. The Random Forest Classifier and Regressor classes are exposed in the modulesclassification
andregression
, respectively, to allow backward compatibility.Fixes #306
Type of change
How Has This Been Tested?
To ensure correct functionality the saved and loaded models have been tested with the test cases already implemented in the library.
Checklist: