Add license to project #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be happy with an MIT but really it's @bryanjos project so I'll leave it with him. |
|
Same answer here. I'd prefer MIT, but ok with Apache 2.0 if that's what @bryanjos chooses. |
|
I'm also fine with MIT |
Add a `LICENSE` file to project to make more explicit the project's terms and conditions.
kennyballou
force-pushed
the
add_license
branch
from
7ae7754 to
5e91979
Compare
|
Reason I deleted the comment was because I noticed this line: Line 39 in 3621653 Because of this, it would be safe to merge this with no issue. If, however, it's preferred to go the path of changing the license to MIT, we would need to get everyone's approval. Less friction to maintain Apache 2.0. |
|
Well that seems pretty clear cut to me! |
|
Thank you @kennyballou ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the license file to the project, make it more explicit that the project is licensed apache 2.0