Attempt to be fancy #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brxck
reviewed
Jun 29, 2021
| @@ -3,6 +3,9 @@ import { SyntaxNode } from "web-tree-sitter"; | |||
| export const getValueNode = (node: SyntaxNode) => | |||
| node.childForFieldName("value"); | |||
|
|
|||
| export const getTypeAnnotationNode = (node: SyntaxNode) => | |||
| node.childForFieldName("type_annotation"); | |||
There was a problem hiding this comment.
So it drove me nuts to figure out, but my understanding is that this won't work.
type_annotation is a named node, but it generally isn't assigned a field name. I don't believe there's an API for accessing nodes by their names.
There are sometimes type fields [1] but unfortunately not in most cases.
brxck
reviewed
Jun 29, 2021
| export function getNodeWithLeadingDelimiter( | ||
| node: SyntaxNode | ||
| ): SelectionWithContext { | ||
| const leadingDelimiterToken = node.previousSibling!; |
There was a problem hiding this comment.
The problem here is that the leading delimiter node : is actually a child of the type_annotation node. We can select the correct delimiter node by passing the last child node of type_annotation (which would be predefined_type or type_identifier) to this matcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't quite gotten this one working, but any chance you could try this direction? Then we could reuse some of this stuff easily for "name" transformation as well