Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IEC (1024) formatting (double i was being added) #71

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Quphoria
Copy link
Contributor

The javascript String.format function, automatically detects that IEC (1024) is being used as a multiple, and adds the "i" for Kibi, Mibi, etc. So the code removed would have added an extra "i" making it KiiB, MiiB, etc.

> String.format('%1024.2mbit', 100000)
'97.66 Kibit'
> String.format('%1000.2mbit', 100000)
'100.00 Kbit'

@brvphoenix brvphoenix merged commit 9155b8d into brvphoenix:master Oct 30, 2023
@Quphoria Quphoria deleted the patch-1 branch October 30, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants