Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to map the cursor directly to touches #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hydr8gon
Copy link

This PR adds a new way to control the mouse cursor. When enabled, the cursor will jump directly to the position of a touch input. The left button is pressed while the touch is active, and the cursor can be dragged in this state. The right button can be pressed with a two-finger tap. This makes the experience of playing certain mouse-based games much better.

@Hate9
Copy link

Hate9 commented Jun 17, 2024

I went to the github page specifically to see if anyone already had a feature request or something for this - lo and behold there's a PR! can't wait for this to get merged (as in I'll probably be building your repo from source)

@ClementCariou
Copy link

ClementCariou commented Jun 18, 2024

Hello,

I've tested this branch, you can improve the following :

  • the "Map cursor directly" option should be available in the "input control" fragment
  • double click doesn't work in this mode, it's anoying for file browsing
  • in the game I tried (Balatro), the click is only registers after the next touch
    ezgif-1-28cf80a111.gif

I think it's still better than original mouse inputs for this kind of game

Btw this project was a mess to build with Gradle.

@TheBoxGame
Copy link

add fix option fix graphics games for example, in ludo race the graphics are not the same as in the screenshot
ludo-race_4
Screenshot_2024-06-19-07-09-51-987_com winlator

@TheBoxGame
Copy link

and also that games that support 1024x768 run even at other resolutions, for example 800x600, 640x480 and others, because when I run games that require a resolution of 1024x768, with the resolution set to 800x600 and 640x480 the game does not start at all, even if you press the icon
Screenshot_2024-06-19-07-14-26-009_com winlator
Screenshot_2024-06-19-07-14-58-378_com winlator

@Hydr8gon
Copy link
Author

Updated to address @ClementCariou's issues.

@ClementCariou
Copy link

@Hydr8gon I've tested your fixes :

  • the click and double click gestures work great now
  • the "Map cursor directly" option in the "input control" fragment crashes
  • there is a build error with the "preferences" attribute missing in TouchpadView, a build CI action would catch this kind of problems

@Hydr8gon
Copy link
Author

I don't get that crash on my end. Also that error doesn't make sense, because TouchpadView doesn't use Preferences anymore. Could you try a clean build with a fresh clone?

@abdulazzem
Copy link

Virgl rnderr full lagging i don't know why i but get more fps when i use exagear & egw The game is smooth, but ever since Winlator was invented, I have had problems with it with the black screen, even though it works well with my friend, but he has a Snapdragon processor. I hve mil i think this issues virgl in winlator

@longjunyu2
Copy link
Contributor

Virgl rnderr full lagging i don't know why i but get more fps when i use exagear & egw The game is smooth, but ever since Winlator was invented, I have had problems with it with the black screen, even though it works well with my friend, but he has a Snapdragon processor. I hve mil i think this issues virgl in winlator

Try changing the Offscreen Rendring Mode from FBO to Backbuffer.

@TheBoxGame
Copy link

@ClementCariou someone has a problem with the graphics in the Ludo Race game

@ClementCariou
Copy link

@ClementCariou someone has a problem with the graphics in the Ludo Race game

Why you mentioned me ? I'm not a contributor.

@TheBoxGame
Copy link

@longjunyu2 I have a question whether the games will work normally despite changing the graphics from 640x480 to 1024x768 and higher, because some games such as Dark Vampires Shadow of Dust run at a resolution of 1024x768 and if I change to 640x480 and 800x600, the game window is too small and on a normal computer the image is full screen even though the resolution is higher: 1920x1080 and others

@TheBoxGame
Copy link

@ClementCariouktoś ma problem z grafiką w grze Ludo Race

Dlaczego o mnie wspomniałeś? Nie jestem współtwórcą.

i don't know Could you please write to the developer to fix this problem?

@Hate9
Copy link

Hate9 commented Jun 26, 2024

Ok, @TheBoxGame and @abdulazzem, can you not use this random fucking PR to talk about unrelated issues? @brunodev85 should ban you from this github tbh. It's annoying af behavior, and if it were up to me your accounts would've been banned sitewide just for this.

@abdulazzem
Copy link

Bruno at your service

@TheBoxGame
Copy link

@brunodev85 I have a question whether the games will work normally despite changing the graphics from 640x480 to 1024x768 and higher, because some games such as Dark Vampires Shadow of Dust run in 1024x768 resolution and if I change to 640x480 and 800x600, the game window is not displayed and the image is too small on a normal computer it is full screen despite the higher resolution: 1920x1080 and others

@Hate9
Copy link

Hate9 commented Jun 26, 2024

oh god they're still fucking going

@TheBoxGame
Copy link

@brunodev85 look
340927984-769f20ea-0e4d-402c-a5eb-60967b34ad8d
340925961-93abd810-05f2-47b9-9b21-f5ddea321a48

@oxters168
Copy link

@TheBoxGame @abdulazzem This is not the place to be asking for help or raising an issue. If you'd like help with your problems then make a post on the Winlator subreddit or somewhere else more appropriate. This is a pull request made by @Hydr8gon to, as the title says, "Add an option to map the cursor directly to touches". The only things you should be commenting in this pull request should be in relation to their contribution. So please do not hijack somebody else's hard work to try and get some help that can be easily gotten elsewhere.

@4Luke4
Copy link

4Luke4 commented Jul 1, 2024

@brunodev85
A bit off topic, but why don't you allow Issues? That is to say, how can users report bugs?

@Wel007
Copy link

Wel007 commented Jul 9, 2024

Alguém sabe como arrumar o bug do controle que fica saindo🥲?

@longjunyu2
Copy link
Contributor

@brunodev85 A bit off topic, but why don't you allow Issues? That is to say, how can users report bugs?

This is an interesting question, you should know that Winlator is a very popular software with many stars. The problems that people encounter during use may come from various reasons, such as wine, box64, turinip, dxvk, etc.
If the project has enabled issue, that area will become a really messsssssss.

@4Luke4
Copy link

4Luke4 commented Jul 14, 2024

@brunodev85 A bit off topic, but why don't you allow Issues? That is to say, how can users report bugs?

This is an interesting question, you should know that Winlator is a very popular software with many stars. The problems that people encounter during use may come from various reasons, such as wine, box64, turinip, dxvk, etc. If the project has enabled issue, that area will become a really messsssssss.

k, but the problem stands still... Are you saying I should open a pull request to report bugs? That would not be good...

@Hate9
Copy link

Hate9 commented Jul 14, 2024

@4Luke4 1: that's not @brunodev85, so what he says in that regard doesn't matter. 2: no, don't do that, that's stupid. 3: this is also not the place to discuss this topic. This is a PR for a specific feature and not a goddamned off-topic community thread!

@Hate9
Copy link

Hate9 commented Jul 14, 2024

I don't get that crash on my end. Also that error doesn't make sense, because TouchpadView doesn't use Preferences anymore. Could you try a clean build with a fresh clone?

@ClementCariou Did you ever end up trying this out?

@ClementCariou
Copy link

Yeah, I still have the problem. I did the following :

  • Go to "Input Controls"
  • Check the "Map cursor directly" option
  • The application crash

Maybe there are some differences on the project compared to your PR. I know I had to make my own gradle config file to be able to build and package the application.

I don't want to spend more time to troubleshoot it myself.

@ClementCariou
Copy link

ClementCariou commented Jul 14, 2024

By the way, can you tell what you have forced pushed recently ? Is it related to this crash ?

@Hydr8gon
Copy link
Author

@ClementCariou if you get a logcat of the crash and upload it, I could look into it. The force push was just a rebase for the latest upstream changes.

@ClementCariou
Copy link

@Xbox-Series-X-User
Copy link

So instead of relative... This is an absolute option?

@Hydr8gon
Copy link
Author

Hydr8gon commented Aug 4, 2024

Finally got around to fixing that crash. It happened when no profile was selected because I forgot a null check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants