This repository was archived by the owner on Dec 8, 2019. It is now read-only.
Fixed MILLION, input slider, and added ON/OFF on power capability#71
Open
lance36 wants to merge 2 commits into
Open
Fixed MILLION, input slider, and added ON/OFF on power capability#71lance36 wants to merge 2 commits into
lance36 wants to merge 2 commits into
Conversation
- added disable interrupts - commented some code - turn led on on power - MILLION fix
lance36
changed the title
JohanLeirnes
reviewed
Mar 1, 2018
| #include <ESP8266WiFi.h> | ||
| #include <PubSubClient.h> | ||
| // Uncomment this if you are experiencing flickering | ||
| //#define FASTLED_ALLOW_INTERRUPTS 0 |
There was a problem hiding this comment.
This has been documented to trigger watchdog resets. Better way is to use this (https://github.com/coryking/FastLED) version of the fastled lib with esp8266 support (no serial support, maby add telnet debugging?)
leograde
approved these changes
Jun 20, 2018
bvansambeek
approved these changes
Jun 20, 2018
bvansambeek
left a comment
bvansambeek
left a comment
There was a problem hiding this comment.
Used these changes and successfully build the project at home. Should be merged ASAP, would have saved me some time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed MILLION, input slider, and addedd ON on power capability