Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overline fix #2450

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Overline fix #2450

merged 3 commits into from
Dec 18, 2024

Conversation

brucemiller
Copy link
Owner

Fix an oversight in #2448, namely that \overbrace,\underbrace include \limits (handled by setting scriptpos=mid), which puts any following scripts above or below. However, lines and arrows should not do this!

@brucemiller brucemiller requested a review from dginev December 18, 2024 18:46
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Our testing framework can't really track these changes all the way to the final rendering which is a pity. One day...

@brucemiller brucemiller merged commit 3abc3af into master Dec 18, 2024
26 checks passed
@brucemiller brucemiller deleted the overline-fix branch December 18, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants