Simplify \lastskip,\lastkern (suggested by D.Ginev) #2424
Conversation
|
Actually, the loops were needed, just unfinished: They needed |
There was a problem hiding this comment.
Looks better, and good to merge ✅
I'm a tiny bit tempted to ask for a tricky test exercising \lastskip and \lastkern, but just voicing the thought for now.
One comment:
Actually, the loops were needed, just unfinished
Let me note again that this was caught by the Rust compiler during porting. It noticed the previous code for the loops only executed one step and exited -- something I (an actual human) missed, while reviewing the other PR. I'm quite excited this happened.
|
The commands are tested, just not the comments special cases (since comments are left out of tests due to variability). Yeah, compilers are good; Thanks Rust! :> |
* Simplify \lastskip,\lastkern (suggested by D.Ginev) * Fix \lastskip,\lastkern by also skipping over any trailing Comment boxes
Simplify
\lastskip(and also simlar\lastkern); as mentioned in last comment in #2423. The code was correct but hadn't been cleaned up after development.