-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect conversion of mathtools symbols like \coloneq and \Coloneq #2418
Conversation
Correct definitions of symbols involving colon
Thank you for contributing this @fiveseven-lambda but it isn't yet finished. Could you (or should we) grep for the macros you are fixing over the entirety of latexml's Package/ directory? For example, here is what Github finds for It would be really nice if we take this chance to sync up the Unicode output across all bindings. |
Regarding |
Indeed, subtle. I am mostly concerned the kind of oversight you are fixing may have happened elsewhere. It didn't help that in the original I have quickly checked the macros you've introduced, and most don't appear in existing bindings, so this PR may be good to go. |
I see, thank you. |
This is all rather curious. As far as I can tell, the bindings were correct when implemented. For whatever reason (mistake?), the packages Now it seems that
It's awkward for packages to introduce breaking changes, but I suppose if we interpret that ":=" was the original intention, we probably should merge your changes, right? |
OK, cool, let's go with it. Thanks for the report and patch!! |
Correct definitions of symbols involving colon
Closes #2410.