Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt a more consistent naming convention for latexml-specific contro… #2361

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

brucemiller
Copy link
Owner

@brucemiller brucemiller commented Apr 30, 2024

…l-sequences.

They usually should start with \lx@, to avoid conflicts with external styles, classes, formats, etc.

To assist in updating any user bindings, a warning is issued when the old names are used (but the new name will be executed).
For reference (and tool building) The old and new names are listed here:

\@ERROR \lx@ERROR
\@@eqno \lx@eqno
\LTX@nonumber \lx@equation@nonumber
\normnal@par \lx@normal@par
\inner@par \lx@normal@par
\hidden@bgroup \lx@hidden@bgroup
\hidden@egroup \lx@hidden@egroup
\right@hidden@egroup \lx@hidden@egroup@right
\hidden@align \lx@hidden@align
\hidden@noalign \lx@hidden@noalign
\hidden@cr \lx@hidden@cr
\hidden@crcr \lx@hidden@crcr
\@start@alignment \lx@start@alignment
\@finish@alignment \lx@finish@alignment
\@close@alignment \lx@close@alignment
\if@in@alignment \if@in@lx@alignment
\@alignment@hline \lx@alignment@hline
\@alignment@newline \lx@alignment@newline
\@alignment@newline@noskip \lx@alignment@newline@noskip \@alignment@newline@marker \lx@alignment@newline@marker \@alignment@newline@markertall \lx@alignment@newline@markertall \@alignment@column \lx@alignment@column
\@alignment@ncolumns \lx@alignment@ncolumns
\@alignment@bindings \lx@alignment@bindings
\@row@before \lx@alignment@row@before
\@row@after \lx@alignment@row@after
\@column@before \lx@alignment@column@before
\@column@after \lx@alignment@column@after
\@tabular@begin@heading \lx@alignment@begin@heading \@tabular@end@heading \lx@alignment@end@heading
\@multicolumn \lx@alignment@multicolumn
\@dollar@in@normalmode \lx@dollar@in@normalmode
\@dollar@in@mathmode \lx@dollar@in@mathmode
\@dollar@in@textmode \lx@dollar@in@textmode
\math@underline \lx@math@underline
\text@underline \lx@text@underline
\math@overleftarrow \lx@math@overleftarrow
\math@overrightarrow \lx@math@overrightarrow
\@@BEGININLINEMATH \lx@begin@inline@math
\@@ENDINLINEMATH \lx@end@inline@math
\@@BEGINDISPLAYMATH \lx@begin@display@math
\@@ENDDISPLAYMATH \lx@end@display@math
\@@BEGININLINETEXT \lx@begin@inmath@text
\@@ENDINLINETEXT \lx@end@inmath@text
\@@FLOATINGSUBSCRIPT \lx@floating@subscript
\@@FLOATINGSUPERSCRIPT \lx@floating@superscript
\@@POSTSUBSCRIPT \lx@post@subscript
\@@POSTSUPERSCRIPT \lx@post@superscript
\@ASSERT@MEANING \lx@assert@meaning

DG: Updating with code block to avoid @-tagging github users

…l-sequences.

They usually should start with \lx@, to avoid conflicts with external styles,
classes, formats, etc.

To assist in updating any user bindings, a warning is issued when the old names are used
(but the new name will be executed).
For reference (and tool building) The old and new names are listed here:
\@error \lx@ERROR
\@@Eqno \lx@eqno
\LTX@nonumber \lx@equation@nonumber
\normnal@par \lx@normal@par
\inner@par \lx@normal@par
\hidden@bgroup \lx@hidden@bgroup
\hidden@egroup \lx@hidden@egroup
\right@hidden@egroup \lx@hidden@egroup@right
\hidden@align \lx@hidden@align
\hidden@noalign \lx@hidden@noalign
\hidden@cr \lx@hidden@cr
\hidden@crcr \lx@hidden@crcr
\@start@alignment \lx@start@alignment
\@finish@alignment \lx@finish@alignment
\@close@alignment \lx@close@alignment
\if@in@alignment \if@in@lx@alignment
\@Alignment@hline \lx@alignment@hline
\@Alignment@newline \lx@alignment@newline
\@Alignment@newline@noskip \lx@alignment@newline@noskip
\@Alignment@newline@marker \lx@alignment@newline@marker
\@Alignment@newline@markertall \lx@alignment@newline@markertall
\@Alignment@column \lx@alignment@column
\@Alignment@ncolumns \lx@alignment@ncolumns
\@Alignment@bindings \lx@alignment@bindings
\@Row@before \lx@alignment@row@before
\@Row@after \lx@alignment@row@after
\@column@before \lx@alignment@column@before
\@column@after \lx@alignment@column@after
\@tabular@begin@heading \lx@alignment@begin@heading
\@tabular@end@heading \lx@alignment@end@heading
\@multicolumn \lx@alignment@multicolumn
\@dollar@in@normalmode \lx@dollar@in@normalmode
\@dollar@in@mathmode \lx@dollar@in@mathmode
\@dollar@in@textmode \lx@dollar@in@textmode
\math@underline \lx@math@underline
\text@underline \lx@text@underline
\math@overleftarrow \lx@math@overleftarrow
\math@overrightarrow \lx@math@overrightarrow
\@@BEGININLINEMATH \lx@begin@inline@math
\@@ENDINLINEMATH \lx@end@inline@math
\@@BEGINDISPLAYMATH \lx@begin@display@math
\@@ENDDISPLAYMATH \lx@end@display@math
\@@BEGININLINETEXT \lx@begin@inmath@text
\@@ENDINLINETEXT \lx@end@inmath@text
\@@FLOATINGSUBSCRIPT \lx@floating@subscript
\@@FLOATINGSUPERSCRIPT \lx@floating@superscript
\@@POSTSUBSCRIPT \lx@post@subscript
\@@POSTSUPERSCRIPT \lx@post@superscript
\@Assert@MEANING \lx@assert@meaning
@brucemiller brucemiller requested a review from dginev April 30, 2024 16:28
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through the code changes - all looks good.

It is a little scary, but the newly achieved consistency is a very neat improvement.

@brucemiller brucemiller merged commit f75b0c6 into master Apr 30, 2024
26 checks passed
@brucemiller brucemiller deleted the internal-cs-naming branch April 30, 2024 21:47
teepeemm pushed a commit to teepeemm/LaTeXML that referenced this pull request Oct 29, 2024
…l-sequences. (brucemiller#2361)

They usually should start with \lx@, to avoid conflicts with external styles,
classes, formats, etc.

To assist in updating any user bindings, a warning is issued when the old names are used
(but the new name will be executed).
For reference (and tool building) The old and new names are listed here:
\@error \lx@ERROR
\@@Eqno \lx@eqno
\LTX@nonumber \lx@equation@nonumber
\normnal@par \lx@normal@par
\inner@par \lx@normal@par
\hidden@bgroup \lx@hidden@bgroup
\hidden@egroup \lx@hidden@egroup
\right@hidden@egroup \lx@hidden@egroup@right
\hidden@align \lx@hidden@align
\hidden@noalign \lx@hidden@noalign
\hidden@cr \lx@hidden@cr
\hidden@crcr \lx@hidden@crcr
\@start@alignment \lx@start@alignment
\@finish@alignment \lx@finish@alignment
\@close@alignment \lx@close@alignment
\if@in@alignment \if@in@lx@alignment
\@Alignment@hline \lx@alignment@hline
\@Alignment@newline \lx@alignment@newline
\@Alignment@newline@noskip \lx@alignment@newline@noskip
\@Alignment@newline@marker \lx@alignment@newline@marker
\@Alignment@newline@markertall \lx@alignment@newline@markertall
\@Alignment@column \lx@alignment@column
\@Alignment@ncolumns \lx@alignment@ncolumns
\@Alignment@bindings \lx@alignment@bindings
\@Row@before \lx@alignment@row@before
\@Row@after \lx@alignment@row@after
\@column@before \lx@alignment@column@before
\@column@after \lx@alignment@column@after
\@tabular@begin@heading \lx@alignment@begin@heading
\@tabular@end@heading \lx@alignment@end@heading
\@multicolumn \lx@alignment@multicolumn
\@dollar@in@normalmode \lx@dollar@in@normalmode
\@dollar@in@mathmode \lx@dollar@in@mathmode
\@dollar@in@textmode \lx@dollar@in@textmode
\math@underline \lx@math@underline
\text@underline \lx@text@underline
\math@overleftarrow \lx@math@overleftarrow
\math@overrightarrow \lx@math@overrightarrow
\@@BEGININLINEMATH \lx@begin@inline@math
\@@ENDINLINEMATH \lx@end@inline@math
\@@BEGINDISPLAYMATH \lx@begin@display@math
\@@ENDDISPLAYMATH \lx@end@display@math
\@@BEGININLINETEXT \lx@begin@inmath@text
\@@ENDINLINETEXT \lx@end@inmath@text
\@@FLOATINGSUBSCRIPT \lx@floating@subscript
\@@FLOATINGSUPERSCRIPT \lx@floating@superscript
\@@POSTSUBSCRIPT \lx@post@subscript
\@@POSTSUPERSCRIPT \lx@post@superscript
\@Assert@MEANING \lx@assert@meaning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants