consistent ifthen.sty dependence in bindings #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dginev
changed the title
teepeemm
pushed a commit
to teepeemm/LaTeXML
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was burning the midnight oil listening to interesting talks...
And happened to walk through the error:undefined:\ifthenelse CorTeX reports. Then I noticed that a number of the articles should have already had the macro supported.
It turns out that some of our bindings should have required
ifthen.sty, as their raw.stycounterparts do - but didn't, since the Perl side never needed the dependency. However, in arXiv, some authors rely on these transitive dependencies being in place and don't loadifthendirectly. So for their sake, here is a simple PR adding them in.