detach tikz figure test, update extra tests #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucemiller
approved these changes
Feb 7, 2024
teepeemm
pushed a commit
to teepeemm/LaTeXML
that referenced
this pull request
Oct 29, 2024
* detach tikz figure example to run only into extra tests (guard from future texlive versions) * updated extratests for newest latexml master, texlive 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2313
This addresses the short-term symptom of the main test suite failing. texlive 2022 and texlive 2023 have differences in pgf and tikz, which may lead to (sometimes reasonable) markup discrepancies in the latexml-generated XML under each texlive.
For now, we avoid testing entirely in such fragile situations. Instead we have an extra target, which can be optionally ran via:
The extra tests are currently expecting a
texlive 2022to succeed.Some of these extras also needed an update following the recent schema changes in latexml, so I've added that update to this PR. I have also checked that the regular tests pass under texlive 2022 and texlive 2023.
Note that the CI tests did not pass under texlive 2023 before this PR, and still do not with it. Those details are tracked by issue #2044, which we deferred to the next milestone (0.8.9)