Implement Wasm validation for known issues/markers (use-ink#171)

* Implement Wasm validation for known issues/markers

* Add test for invalid panic import

* Add prefix to error markers

* Add test for ink! codegen error marker

* Implement improved linker error protocol

* Move validation into its own module

* Migrate tests to new linker error protocol

* Fix merge

* Improve code structure

* Fix formatting

* Improve code structure

* Remove mod indirection

* Replace `contains` with `starts_with`

* Add note regarding equivalent ink! type necessity

* Throw an error on invalid import function

* Add sunny day test

* Do not panic if no import section is found

* Update error message on decoding error

Cargo.toml

@@ -28,7 +28,7 @@ zip = { version = "0.5.8", default-features = false }
 pwasm-utils = "0.17.0"
 parity-wasm = "0.42.1"
 cargo_metadata = "0.12.3"
-codec = { package = "parity-scale-codec", version = "2.0.0" }
+codec = { package = "parity-scale-codec", version = "2.0.0", features = ["derive"] }
 which = "4.0.2"
 colored = "2.0.0"
 toml = "0.5.8"
@@ -41,6 +41,7 @@ serde_json = "1.0.62"
 tempfile = "3.2.0"
 url = { version = "2.2.0", features = ["serde"] }
 binaryen = { version = "0.12.0", optional = true }
+impl-serde = "0.3.1"
 
 # dependencies for optional extrinsics feature
 async-std = { version = "1.9.0", optional = true }

src/cmd/build.rs

@@ -26,7 +26,7 @@ use std::{io, process::Command};
 
 use crate::{
     crate_metadata::CrateMetadata,
-    maybe_println, util,
+    maybe_println, util, validate_wasm,
     workspace::{ManifestPath, Profile, Workspace},
     BuildArtifacts, BuildResult, UnstableFlags, UnstableOptions, VerbosityFlags,
 };
@@ -252,6 +252,8 @@ fn post_process_wasm(crate_metadata: &CrateMetadata) -> Result<()> {
     ensure_maximum_memory_pages(&mut module, MAX_MEMORY_PAGES)?;
     strip_custom_sections(&mut module);
 
+    validate_wasm::validate_import_section(&module)?;
+
     parity_wasm::serialize_to_file(&crate_metadata.dest_wasm, module)?;
     Ok(())
 }
@@ -436,7 +438,7 @@ pub(crate) fn execute_with_crate_metadata(
 
 #[cfg(feature = "test-ci-only")]
 #[cfg(test)]
-mod tests {
+mod tests_ci_only {
     use crate::{cmd, util::tests::with_tmp_dir, BuildArtifacts, ManifestPath, UnstableFlags};
 
     #[test]

src/main.rs

@@ -17,6 +17,7 @@
 mod cmd;
 mod crate_metadata;
 mod util;
+mod validate_wasm;
 mod workspace;
 
 use self::workspace::ManifestPath;