Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mempool): dont panic on SIGTERM #339

Merged
merged 3 commits into from
Oct 31, 2024
Merged

feat(mempool): dont panic on SIGTERM #339

merged 3 commits into from
Oct 31, 2024
+88 −33

Conversation

pashinov
Copy link
Member

No description provided.

@pashinov pashinov requested a review from Mododo September 30, 2024 10:18
@pashinov pashinov force-pushed the feature/mempool-graceful-shutdown branch 2 times, most recently from 0425430 to 318f540 Compare September 30, 2024 15:22
@Mododo Mododo force-pushed the feature/mempool-graceful-shutdown branch from 318f540 to 807d3b7 Compare October 31, 2024 14:24
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.38889% with 71 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
consensus/src/intercom/broadcast/broadcaster.rs 0.00% 16 Missing ⚠️
consensus/src/intercom/peer_schedule/stateless.rs 0.00% 14 Missing and 1 partial ⚠️
consensus/src/intercom/peer_schedule/impl_.rs 6.66% 13 Missing and 1 partial ⚠️
consensus/src/intercom/dependency/downloader.rs 0.00% 11 Missing ⚠️
collator/src/mempool/impls/std_impl.rs 0.00% 8 Missing ⚠️
consensus/src/intercom/broadcast/collector.rs 0.00% 4 Missing ⚠️
consensus/src/engine/input_buffer.rs 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Mododo Mododo requested a review from Rexagon October 31, 2024 15:09
@Mododo
Copy link
Member

Mododo commented Oct 31, 2024

should squash commits

@pashinov
Copy link
Member Author

LGTM

@Mododo Mododo force-pushed the feature/mempool-graceful-shutdown branch from a5e2539 to 76388fc Compare October 31, 2024 18:47
@Rexagon Rexagon merged commit 98fa59e into master Oct 31, 2024
6 of 8 checks passed
@Rexagon Rexagon deleted the feature/mempool-graceful-shutdown branch October 31, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mododo Mododo Mododo approved these changes

@Rexagon Rexagon Awaiting requested review from Rexagon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pashinov @Mododo @Rexagon