Skip to content

SDK-667 : Limit VCS info to 64kb #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2024
Merged

SDK-667 : Limit VCS info to 64kb #834

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01de260
Limit VCS info to 64kb
TamsilAmani May 20, 2024
076bf3b
Add Object check and log info for new truncated size
TamsilAmani May 20, 2024
34cf476
Fix: use math.ceil, calculations in bytes
TamsilAmani May 23, 2024
dc92647
modify constant value
TamsilAmani May 23, 2024
798bf97
Remove variable use
TamsilAmani May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove variable use
  • Loading branch information
@TamsilAmani
TamsilAmani committed May 23, 2024
commit 798bf97c72b556e5c226b651785b683f79df9aaf
3 changes: 1 addition & 2 deletions bin/helpers/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,8 +402,7 @@ exports.checkAndTruncateVCSInfo = (gitMetaData) => {

if (gitMetaDataSizeInBytes && gitMetaDataSizeInBytes > MAX_GIT_META_DATA_SIZE_IN_BYTES) {
const truncateSize = gitMetaDataSizeInBytes - MAX_GIT_META_DATA_SIZE_IN_BYTES;
const truncatedCommitMessage = exports.truncateString(gitMetaData.commit_message, truncateSize);
gitMetaData.commit_message = truncatedCommitMessage;
gitMetaData.commit_message = exports.truncateString(gitMetaData.commit_message, truncateSize);
logger.info(`The commit has been truncated. Size of commit after truncation is ${ exports.getSizeOfJsonObjectInBytes(gitMetaData) / 1024} KB`);
}

Expand Down