-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a pre-commit hook #8
Conversation
Signed-off-by: Ali Sajid Imami <395482+AliSajid@users.noreply.github.com>
For what tool we need this YAML file? Can you explain me a little more? |
This yaml implementation is a part of the You can see the following pre-commit enabled repositories: The repos:
repo: https://github.com/browserslist
hooks:
- id: browserslist-lint |
Co-authored-by: Andrey Sitnik <andrey@sitnik.ru>
Signed-off-by: Ali Sajid Imami <395482+AliSajid@users.noreply.github.com>
I am back :D What do you think of moving it to https://github.com/browserslist/lint If we add some linter it will be more relevant to use linter’s URL? |
I'm confused. Isn't this the browserslist/lint repository? I thought it was. If it's not, I'd be happy to move it. |
Oh, too much work. I thought that it was Browserslist repo 😅. Thanks, merged. |
Thank you! I appreciate the opportunity to contribute! |
This pull request introduces a pre-commit hook for validating Browserslist configurations. The most important changes include the addition of a configuration file for the pre-commit hooks. There are also relevant additions to the
README.md
.Pre-commit hook addition:
pre-commit-hooks.yaml
: Defined a new hook,browserslist-lint
, to validate Browserslist configurations usingnpx browserslist-linter
. This hook is triggered by changes to.browserslistrc
orpackage.json
.Documentation updates:
README.md
: Added a section on the pre-commit hook, including instructions on how to add it to the pre-commit configuration.