Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tarballs with nested folders for release archives #40

Merged
merged 4 commits into from
Apr 7, 2019
Merged

Use tarballs with nested folders for release archives #40

merged 4 commits into from
Apr 7, 2019

Conversation

maximbaz
Copy link
Member

@maximbaz maximbaz commented Apr 6, 2019

Fixes #39

@maximbaz maximbaz mentioned this pull request Apr 6, 2019
Closed
erayd
erayd approved these changes Apr 7, 2019
View reviewed changes
Copy link
Collaborator

@erayd erayd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you for making this change :-).

Makefile Outdated
if [ "$$os" = "windows64" ]; then \
(cd $(TMP) && zip -FSr ${CURDIR}/dist/browserpass-"$$os"-$(VERSION).zip browserpass-"$$os"-$(VERSION)); \
else \
(cd $(TMP) && tar -cvf ${CURDIR}/dist/browserpass-"$$os"-$(VERSION).tar.gz --use-compress-program=gzip browserpass-"$$os"-$(VERSION)); \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why --use-compress-program=gzip rather than simply using -z. It doesn't matter either way, and the result is identical, but the choice of syntax is unusual.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't usually use tar directly so I simply didn't know about -z flag, I use a helper script from prezto, so I took the command from their sources - and their command looks like --use-compress-program=pigz because they use parallel compression 🙂

But for this Makefile will simplify, since archives are small and I wasn't planning to use parallel compression here anyway.

@maximbaz maximbaz merged commit 04d4d67 into browserpass:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erayd erayd erayd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximbaz @erayd