[WIP] require browser version of create-hmac in browser.js

[fanatid]

No description provided.

[dcousens]

Why?

[fanatid]

because create-hmac does same https://github.com/crypto-browserify/createHmac/blob/27f170f06fd958070d3e848afc706c4cc4debda5/browser.js#L2
it gives ability to use pure javascript pbkdf2 with pure hmac/hash

[dcousens]

And what about if I wanted javascript pbkdf2 and native HMAC?

[fanatid]

Can you describe your case?

[dcousens]

@fanatid PBKDF-SHA256 on Node 10 (though, its not so relevant now)

[fanatid]

oh, I forgot about this :(
but I still think, that browser by default should export pure javascript version

maybe we should make something like this?

function createPBKDF2 (hmac) {
 ...
}

module.exports = createPBKDF2(require('create-hmac/browser'))
module.exports.native = createPBKDF2(require('create-hmac'))

or move node v0.10 code to another file?

[fanatid]

Related project where would be nice have pure js pbkdf2: https://github.com/cryptocoinjs/scryptsy

[dcousens]

Why does that need pure JS pbkdf2?

[fanatid]

Honestly, I don't know :)
maybe for somebody it will be reasonable use pure js, because it easy for review
or use pure js for benchmarks

[dcousens]

NACK, you can force browser via browserify if you need to IIRC?

[fanatid]

ok, I'll close this right now,
but we can back to this issue in October 2016, when node v0.10 will no longer maintenance :)

[dcousens]

👍