Skip to content

Add off shortcut for removeListener #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add off shortcut for removeListener #42

wants to merge 1 commit into from

Conversation

@grifotv
Copy link

@grifotv grifotv commented Oct 19, 2017

So it's consistent with on shortcut

@grifotv
Add off shortcut for removeListener
e105aae 
So it's consistent with `on` shortcut
@goto-bus-stop
Copy link
Member

goto-bus-stop commented Jan 31, 2018

thanks, but events is supposed to be an implementation of the Node events API, which doesn't have an off function. adding one would be a breaking change and would make it difficult to use events as a drop in replacement for the Node core module in the browser.

@goto-bus-stop goto-bus-stop reopened this Jan 31, 2018
@goto-bus-stop
Copy link
Member

goto-bus-stop commented Jan 31, 2018

nodejs/node#17156 missed this!

@goto-bus-stop
Copy link
Member

goto-bus-stop commented Apr 25, 2018 •
edited
Loading

@grifotv Node 10 was released yesterday with the EventEmitter.prototype.off method. Would you mind rebasing this PR? :)

@goto-bus-stop goto-bus-stop mentioned this pull request May 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grifotv @goto-bus-stop