Skip to content

Conversation

sreekanth370
Copy link

Added power support for the travis.yml file with ppc64le. This is part of the Ubuntu distribution for ppc64le.
This helps us simplify testing later when distributions are re-building and re-releasing.

@goto-bus-stop
Copy link
Member

@sreekanth370 the same applies here as in browserify/commonjs-assert#51, no?

@sreekanth370
Copy link
Author

both applies same , kindly merge the code with power support architecture .

@goto-bus-stop
Copy link
Member

What is the purpose? This module is pure JavaScript.

This PR also removes many Node.js versions from CI which does not make sense to me.

IMO all of these ppc64le PRs are submitted with way too little explanation of what they do and why they do it.

@sreekanth370
Copy link
Author

Hey , Not sure how familiar you are with the Power architecture - primarily the bigger enterprise class systems from IBM for banking/insurance/retail/etc.etc but this ensures that your code and all dependencies are tested on the Power architecture. Debian/Ubuntu, and Fedora/RHEL/CentOS have ppc64le (Power) distributions and this code goes into those distributions. This ensures that top of tree is always validated on ppc64le using (free) Power servers at Travis CI.

@ljharb
Copy link
Member

ljharb commented Dec 2, 2020

There’s no value in ensuring it’s validated on that architecture when the code can’t behave differently on it.

@sreekanth370
Copy link
Author

For more info tag @gerrith3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants