Skip to content

Implement assert.match() and assert.doesNotMatch() #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

Implement assert.match() and assert.doesNotMatch() #54

merged 1 commit into from
Oct 21, 2022

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@RaisinTen
Copy link
Contributor Author

cc @BridgeAR

ljharb
ljharb reviewed Nov 24, 2021
View reviewed changes
@RaisinTen RaisinTen force-pushed the match-and-doesNotMatch branch from 8bd0390 to 8a38000 Compare November 25, 2021 08:06
@RaisinTen RaisinTen requested a review from ljharb November 25, 2021 08:10
ljharb
ljharb reviewed Nov 25, 2021
View reviewed changes
@RaisinTen RaisinTen force-pushed the match-and-doesNotMatch branch from 8a38000 to b4e06ac Compare November 26, 2021 06:04
@RaisinTen RaisinTen requested a review from ljharb November 26, 2021 06:12
@RaisinTen RaisinTen force-pushed the match-and-doesNotMatch branch from b4e06ac to 1fc017e Compare November 26, 2021 07:29
RaisinTen
RaisinTen commented Nov 26, 2021
View reviewed changes
ljharb
ljharb reviewed Nov 27, 2021
View reviewed changes
@RaisinTen
Implement assert.match() and assert.doesNotMatch()
4922dee 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the match-and-doesNotMatch branch from 1fc017e to 4922dee Compare November 27, 2021 15:19
@RaisinTen RaisinTen requested a review from ljharb November 27, 2021 15:20
@RaisinTen
Copy link
Contributor Author

@ljharb @BridgeAR Is there a minimum waiting time before we can land this PR and make a new release? I couldn't find any documentation for the process.

@ljharb ljharb requested a review from goto-bus-stop November 29, 2021 07:55
@RaisinTen
Copy link
Contributor Author

ping @goto-bus-stop ^

@ljharb
Copy link
Member

ljharb commented Dec 2, 2021

@RaisinTen pinging them multiple times is just annoying, it's not going to make anything happen faster. They'll get to it when they have time, and not before.

@BridgeAR BridgeAR merged commit d932a53 into browserify:master Oct 21, 2022
@RaisinTen RaisinTen deleted the match-and-doesNotMatch branch October 21, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@goto-bus-stop goto-bus-stop Awaiting requested review from goto-bus-stop

+1 more reviewer

@AlxKrispy AlxKrispy AlxKrispy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaisinTen @ljharb @BridgeAR @AlxKrispy