Skip to content

Added power support for the travis.yml file with ppc64le . package: commonjs-assert #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added power support for the travis.yml file with ppc64le . package: commonjs-assert #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e4769b
test
sreekanth370 Nov 2, 2020
7770070
test
sreekanth370 Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: node_js
arch:
- amd64
- ppc64le
node_js:
- 'stable'
- '12'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We absolutely can’t stop testing on these node versions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, can't stop on these versions .kindly merge the code with power architecture.

Power architecture - primarily the bigger enterprise class systems from IBM for banking/insurance/retail/etc.etc but this ensures that your code and all dependencies are tested on the Power architecture. Debian/Ubuntu, and Fedora/RHEL/CentOS have ppc64le (Power) distributions and this code goes into those distributions. This ensures that top of tree is always validated on ppc64le using (free) Power servers at Travis CI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code that doesn’t touch the filesystem, and isn’t using native modules, basically can’t vary by architecture - there’s no value in testing on it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For more info tag @gerrith3

- '10'
- '8'
- '6'
script:
- 'npm test'
Expand Down