Added test cases for assert.fail and implemented corresponding changes #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemented changes so all existing and all new tests pass.
|
Sorry that this has not been looked at earlier. It seems like it's superseded by #44 now. @goto-bus-stop @lukechilds |
BridgeAR
previously approved these changes
May 6, 2019
|
Closing since #44 landed. @don01001000 thanks a lot for your contribution and sorry that this could not land! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me based on the documentation that
assert.fail(message)should throw an exception for which themessageproperty is just the message passed in. However, it's being set to whatevermessageis wrapped in single quotes and followed byundefined undefined.See #34.