fix for enviroments that don't have node.js stuff

[calvinmetcalf]

apparently this library is popular with react-native which offers require but doesn't provide any of the built in node.js things

[defunctzombie]

Please don't do dependencies like this. Dependencies should be specified exactly.

Also, this dependency bloats this module a lot. But maybe un-avoidable.

[calvinmetcalf]

ok removed the carrot

[calvinmetcalf]

ok can squash, merge and publish if it's ok with you @defunctzombie

[defunctzombie]

👍 I would be cautious of how much overhead having buffer adds btw. If all this is used for is an "isBuffer" check then inlining that into the module is way better than having the whole module used for client side builds.

[calvinmetcalf]

hm good point

On Mon, May 23, 2016 at 12:25 PM Roman Shtylman notifications@github.com
wrote:

👍 I would be cautious of how much overhead having buffer adds btw. If
all this is used for is an "isBuffer" check then inlining that into the
module is way better than having the whole module used for client side
builds.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#22 (comment)

[calvinmetcalf]

ok I did it, but then also thought, hey I should put in some tests ... yeah so monstly passing except in certain browser envs

[calvinmetcalf]

ok looks like we now pass all the new tests, will merge in a bit if nobody objects

[calvinmetcalf]

(and obviously squash it)