upgrade bn and add 2 curves #22
Conversation
|
crypto-browserify/crypto-browserify#140 |
|
removed p521 as that can be added back in a minor version |
calvinmetcalf
changed the title
|
@dcousens if we can get this merged then I can start work on the next phase upgrade of bn.js |
| @@ -16,13 +16,13 @@ | |||
| "author": "", | |||
| "license": "ISC", | |||
| "dependencies": { | |||
| "bn.js": "^2.0.0", | |||
| "browserify-rsa": "^2.0.0", | |||
| "bn.js": "^3.0.0", | |||
There was a problem hiding this comment.
why not 3.2.0? You have been switching between 3.2.0 and 3.0.0.
Do we need 3.2.0?
There was a problem hiding this comment.
Some I manually incremented the major digit and others I used npm
Why not just add both? Any reason? |
|
P521 needed a fix in elliptical that just landed but is part of the next On Wed, Oct 28, 2015, 9:12 PM Daniel Cousens notifications@github.com
|
|
@calvinmetcalf should we just wait and land both? |
|
We have to bump a bunch of stuff to the next version of bn.js before we can do this one. |
This reverts commit 352ea17.
calvinmetcalf
changed the title
calvinmetcalf
changed the title
|
GREEN! thanks to indutny/bn.js@3158625 |
|
ACK 👍 |
No description provided.