Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE file. #21

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Add LICENSE file. #21

merged 1 commit into from
Oct 15, 2015

Conversation

mkillianey
Copy link
Contributor

I've added the ISC license. (Not sure whether or not this was intentionally licensed as ISC instead of MIT, like some of the other crypto-browserify packages...please let me know if this isn't what you wanted.)

@dcousens
Copy link
Member

Granted the main contributor is @calvinmetcalf, I'd prefer if it said:

Copyright (c) 2015 browserify-sign contributors

or something

@calvinmetcalf
Copy link
Contributor

A couple things

  • I've privatized myself and no longer work for the state so I know use a Gmail account primarily.
  • we probably want at least one name in the licence.

@dcousens
Copy link
Member

we probably want at least one name in the licence.

Any reason?

@calvinmetcalf
Copy link
Contributor

So there is somebody that a person can email or contact or something I
figure it can't hurt.

On Wed, Oct 14, 2015, 5:30 PM Daniel Cousens notifications@github.com
wrote:

we probably want at least one name in the licence.

Any reason?


Reply to this email directly or view it on GitHub
#21 (comment)
.

@dcousens
Copy link
Member

dcousens commented Oct 14, 2015

@calvinmetcalf maybe put that in a contributor list item then?
It seemed odd to me that projects often have hundreds of contributors, and then just 1 copyright holder.
I'd rather see the copyrights just listed as those who did the work, plain and simply.

@calvinmetcalf
Copy link
Contributor

I didn't say only one copyright holder, I was thinking (c) name and
contributors

On Wed, Oct 14, 2015 at 6:07 PM Daniel Cousens notifications@github.com
wrote:

@calvinmetcalf https://github.com/calvinmetcalf maybe put that in a
contributor list item then?
It seemed odd to me that projects often have hundreds of contributors, and
then just 1 copyright holder.
I'd rather see the copyrights just assigned to those who did the work,
plain and simply.


Reply to this email directly or view it on GitHub
#21 (comment)
.

@dcousens
Copy link
Member

@calvinmetcalf works for me, semantically the same but addresses the issue you raised. 👍

@mkillianey are you up to make that change?

@mkillianey mkillianey changed the title Add LICENSE and author info. Add LICENSE file. Oct 15, 2015
@mkillianey
Copy link
Contributor Author

Happy to make the change (and/or have you make the change), whichever's less trouble for you.

I'm not a lawyer, so I don't know if there's a downside to listing "browserify-sign contributors" in the copyright. For example, if you eventually take this pull request, does that mean that I'm a contributor, and does that confer some rights to me that I really shouldn't have? Or do we kinda trust that licenses like ISC and MIT make that a moot point?

As for the author/contributors fields in the package.json, I'll uncomplicate the pull request(s) by removing that change from all my browserify pull requests. For my purposes, I just want to know what text I should use to fairly/correctly acknowledge your wonderful work.

@calvinmetcalf
Copy link
Contributor

@mkillianey I think we want to go with (for this one) Calvin Metcalf & contributors

dcousens added a commit that referenced this pull request Oct 15, 2015
@dcousens dcousens merged commit 366385b into browserify:master Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants